From: Daniel Schwierzeck <daniel.schwierzeck@gmail.com>
To: u-boot@lists.denx.de
Subject: [PATCH 07/36] bdinfo: microblaze: Use the generic bd command
Date: Wed, 6 May 2020 17:56:10 +0200 [thread overview]
Message-ID: <1e2a4214-0a62-0682-9473-e3dd52220528@gmail.com> (raw)
In-Reply-To: <20200504171638.7.Ic4c05106579f39e7418db0a149582bc992327326@changeid>
Am 05.05.20 um 01:17 schrieb Simon Glass:
> Microblaze prints out ethernet and FDT information. This is useful to
> most archs, so move it into the generic code and move microblaze over to
> use it.
>
> Signed-off-by: Simon Glass <sjg@chromium.org>
> ---
>
> cmd/bdinfo.c | 30 +++++++-----------------------
> 1 file changed, 7 insertions(+), 23 deletions(-)
>
> diff --git a/cmd/bdinfo.c b/cmd/bdinfo.c
> index 405a915861..dc5a09f8ce 100644
> --- a/cmd/bdinfo.c
> +++ b/cmd/bdinfo.c
> @@ -224,29 +224,7 @@ int do_bdinfo(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
>
> #elif defined(CONFIG_MICROBLAZE)
>
> -int do_bdinfo(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
> -{
> - bd_t *bd = gd->bd;
> -
> - print_bi_dram(bd);
> - print_bi_flash(bd);
> -#if defined(CONFIG_SYS_SRAM_BASE)
> - print_num("sram start ", (ulong)bd->bi_sramstart);
> - print_num("sram size ", (ulong)bd->bi_sramsize);
> -#endif
> -#if defined(CONFIG_CMD_NET) && !defined(CONFIG_DM_ETH)
> - print_eths();
> -#endif
> - print_baudrate();
> - print_num("relocaddr", gd->relocaddr);
> - print_num("reloc off", gd->reloc_off);
> - print_num("fdt_blob", (ulong)gd->fdt_blob);
> - print_num("new_fdt", (ulong)gd->new_fdt);
> - print_num("fdt_size", (ulong)gd->fdt_size);
> - print_cpu_word_size();
> -
> - return 0;
> -}
> +#define USE_GENERIC
>
> #elif defined(CONFIG_M68K)
>
> @@ -463,6 +441,12 @@ int do_bdinfo(cmd_tbl_t *cmdtp, int flag, int argc, char *const argv[])
> print_num("relocaddr", gd->relocaddr);
> print_num("reloc off", gd->reloc_off);
> print_cpu_word_size();
> +#if defined(CONFIG_CMD_NET) && !defined(CONFIG_DM_ETH)
> + print_eths();
> +#endif
> + print_num("fdt_blob", (ulong)gd->fdt_blob);
> + print_num("new_fdt", (ulong)gd->new_fdt);
> + print_num("fdt_size", (ulong)gd->fdt_size);
shouldn't that be guarded with CONFIG_IS_ENABLED(OF_LIBFDT) ?
>
> return 0;
> }
>
--
- Daniel
next prev parent reply other threads:[~2020-05-06 15:56 UTC|newest]
Thread overview: 93+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-04 23:16 [PATCH 00/36] Tidy up the 'bd' command Simon Glass
2020-05-04 23:16 ` [PATCH 01/36] bdinfo: nds32: Use generic bd_info Simon Glass
[not found] ` <752D002CFF5D0F4FA35C0100F1D73F3FA4704736@ATCPCS16.andestech.com>
2020-05-05 1:16 ` Rick Chen
2020-05-06 8:06 ` Bin Meng
2020-05-04 23:16 ` [PATCH 02/36] bdinfo: riscv: " Simon Glass
[not found] ` <752D002CFF5D0F4FA35C0100F1D73F3FA4704741@ATCPCS16.andestech.com>
2020-05-05 1:19 ` Rick Chen
2020-05-06 8:06 ` Bin Meng
2020-05-04 23:16 ` [PATCH 03/36] bdinfo: m68k: Drop bd_info->bi_ipbfreq Simon Glass
2020-05-06 8:06 ` Bin Meng
2020-05-04 23:17 ` [PATCH 04/36] bdinfo: xtensa: Create a generic do_bdinfo for xtensa Simon Glass
2020-05-06 8:07 ` Bin Meng
2020-05-04 23:17 ` [PATCH 05/36] bdinfo: mips: Use the generic bd command Simon Glass
2020-05-06 8:07 ` Bin Meng
2020-05-06 15:29 ` Daniel Schwierzeck
2020-05-04 23:17 ` [PATCH 06/36] bdinfo: nios2: " Simon Glass
2020-05-06 8:07 ` Bin Meng
2020-05-04 23:17 ` [PATCH 07/36] bdinfo: microblaze: " Simon Glass
2020-05-06 8:07 ` Bin Meng
2020-05-06 15:56 ` Daniel Schwierzeck [this message]
2020-05-10 20:36 ` Simon Glass
2020-05-04 23:17 ` [PATCH 08/36] bdinfo: sh: " Simon Glass
2020-05-06 8:07 ` Bin Meng
2020-05-04 23:17 ` [PATCH 09/36] bdinfo: x86: " Simon Glass
2020-05-06 8:07 ` Bin Meng
2020-05-04 23:17 ` [PATCH 10/36] bdinfo: sandbox: " Simon Glass
2020-05-06 8:07 ` Bin Meng
2020-05-04 23:17 ` [PATCH 11/36] bdinfo: nds32: " Simon Glass
[not found] ` <752D002CFF5D0F4FA35C0100F1D73F3FA470474E@ATCPCS16.andestech.com>
2020-05-05 1:22 ` Rick Chen
2020-05-06 8:07 ` Bin Meng
2020-05-04 23:17 ` [PATCH 12/36] bdinfo: riscv: " Simon Glass
[not found] ` <752D002CFF5D0F4FA35C0100F1D73F3FA4704755@ATCPCS16.andestech.com>
2020-05-05 1:24 ` Rick Chen
2020-05-06 8:07 ` Bin Meng
2020-05-04 23:17 ` [PATCH 13/36] bdinfo: arm: " Simon Glass
2020-05-06 8:07 ` Bin Meng
2020-05-04 23:17 ` [PATCH 14/36] bdinfo: Drop the option to not use the generic 'bd' command Simon Glass
2020-05-06 8:07 ` Bin Meng
2020-05-04 23:17 ` [PATCH 15/36] bdinfo: Drop unused __maybe_unused Simon Glass
2020-05-06 8:07 ` Bin Meng
2020-05-04 23:17 ` [PATCH 16/36] bdinfo: microblaze: sh: nios2: Drop arch-specific flash info Simon Glass
2020-05-06 8:09 ` Bin Meng
2020-05-04 23:17 ` [PATCH 17/36] bdinfo: Drop unnecessary inline on functions Simon Glass
2020-05-06 8:09 ` Bin Meng
2020-05-04 23:17 ` [PATCH 18/36] bdinfo: Drop print_std_bdinfo() Simon Glass
2020-05-06 8:09 ` Bin Meng
2020-05-04 23:17 ` [PATCH 19/36] bdinfo: ppc: Drop arch-specific print_baudrate() Simon Glass
2020-05-06 8:09 ` Bin Meng
2020-05-06 15:09 ` Stefan Roese
2020-05-04 23:17 ` [PATCH 20/36] bdinfo: sh: arc: Drop arch-specific print_bi_mem() Simon Glass
2020-05-06 8:09 ` Bin Meng
2020-05-06 9:04 ` Alexey Brodkin
2020-05-04 23:17 ` [PATCH 21/36] bdinfo: Drop print_bi_boot_params() Simon Glass
2020-05-06 8:09 ` Bin Meng
2020-05-04 23:17 ` [PATCH 22/36] bdinfo: Drop print_bi_flash() Simon Glass
2020-05-06 8:09 ` Bin Meng
2020-05-06 14:10 ` Tom Rini
2020-05-06 14:47 ` Simon Glass
2020-05-04 23:17 ` [PATCH 23/36] bdinfo: Drop print_cpu_word_size() Simon Glass
2020-05-06 8:09 ` Bin Meng
2020-05-04 23:17 ` [PATCH 24/36] bdinfo: net: ppc: Drop bi_enet1addr and other similar info Simon Glass
2020-05-06 8:09 ` Bin Meng
2020-05-06 15:09 ` Stefan Roese
2020-05-04 23:17 ` [PATCH 25/36] bdinfo: net: ppc: Drop prints for CONFIG_HAS_ETHn Simon Glass
2020-05-06 8:09 ` Bin Meng
2020-05-06 15:10 ` Stefan Roese
2020-05-04 23:17 ` [PATCH 26/36] bdinfo: net: Drop legacy ethernet bdinfo Simon Glass
2020-05-06 8:09 ` Bin Meng
2020-05-06 14:47 ` Simon Glass
2020-05-04 23:17 ` [PATCH 27/36] bdinfo: net: Inline print_eths() Simon Glass
2020-05-06 8:10 ` Bin Meng
2020-05-04 23:17 ` [PATCH 28/36] bdinfo: net: Inline print_eth_ip_addr() Simon Glass
2020-05-06 8:10 ` Bin Meng
2020-05-04 23:17 ` [PATCH 29/36] bdinfo: Export some basic printing functions Simon Glass
2020-05-06 8:10 ` Bin Meng
2020-05-04 23:17 ` [PATCH 30/36] bdinfo: arm: Move ARM-specific info into its own file Simon Glass
2020-05-06 8:10 ` Bin Meng
2020-05-06 16:10 ` Daniel Schwierzeck
2020-05-04 23:17 ` [PATCH 31/36] bdinfo: ppc: Move PPC-specific " Simon Glass
2020-05-06 8:10 ` Bin Meng
2020-05-06 15:10 ` Stefan Roese
2020-05-04 23:17 ` [PATCH 32/36] bdinfo: m68k: Move m68k-specific " Simon Glass
2020-05-06 8:10 ` Bin Meng
2020-05-06 20:11 ` Angelo Dureghello
2020-05-04 23:17 ` [PATCH 33/36] bdinfo: m68k: ppc: Move arch-specific code from bdinfo Simon Glass
2020-05-06 8:10 ` Bin Meng
2020-05-06 15:10 ` Stefan Roese
2020-05-04 23:17 ` [PATCH 34/36] bdinfo: Update the file comments Simon Glass
2020-05-06 8:10 ` Bin Meng
2020-05-04 23:17 ` [PATCH 35/36] bdinfo: dm: Update fb_base when using driver model Simon Glass
2020-05-06 8:10 ` Bin Meng
2020-05-04 23:17 ` [PATCH 36/36] bdinfo: x86: vesa: Update fb_base to the correct value Simon Glass
2020-05-06 8:10 ` Bin Meng
2020-05-06 9:28 ` [PATCH 00/36] Tidy up the 'bd' command Alexey Brodkin
2020-05-06 14:47 ` Simon Glass
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1e2a4214-0a62-0682-9473-e3dd52220528@gmail.com \
--to=daniel.schwierzeck@gmail.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox