public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Alex Marginean <alexm.osslist@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v4 1/4] armv8: ls1028a: The ls1028a platform supports the I2C driver model
Date: Fri, 12 Jul 2019 14:46:58 +0300	[thread overview]
Message-ID: <1eab499d-234a-4db3-724e-22d318778a94@gmail.com> (raw)
In-Reply-To: <20190710131652.28358-1-chuanhua.han@nxp.com>

On 7/10/2019 4:16 PM, Chuanhua Han wrote:
> DM_I2C_COMPAT is a compatibility layer that allows using the non-DM
> I2C API when DM_I2C is used.When DM_I2C_COMPAT is not enabled for
> compilation, a compilation error will be generated. This patch
> solves the problem that the i2c-related api of the ls1028a platform
> does not support dm.

I wouldn't mention DM_I2C_COMPAT at all in the commit message, it's not
currently enabled and after this patch set it's not needed either.
You could just mention that the patch is updating ls1028a board init
code to support DM_I2C.

> 
> Signed-off-by: Chuanhua Han <chuanhua.han@nxp.com>
> ---
> depends on:
> 	- https://patchwork.ozlabs.org/project/uboot/list/?series=113364
> 	- https://patchwork.ozlabs.org/project/uboot/list/?series=110856
> 	- https://patchwork.ozlabs.org/project/uboot/list/?series=109677
> 
> Changes in v4:
> 	- No change.
> Changes in v3:
> 	- No change.
> Changes in v2:
> 	- No change.
> 
>   arch/arm/cpu/armv8/fsl-layerscape/Kconfig |    8 --------
>   board/freescale/ls1028a/ls1028a.c         |    8 ++++++++
>   include/configs/ls1028a_common.h          |    3 ---
>   include/configs/ls1028ardb.h              |    1 -
>   4 files changed, 8 insertions(+), 12 deletions(-)
> 

code changes look OK to me.

Reviewed-by: Alex Marginean <alexm.osslist@gmail.com>

  parent reply	other threads:[~2019-07-12 11:46 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-10 13:16 [U-Boot] [PATCH v4 1/4] armv8: ls1028a: The ls1028a platform supports the I2C driver model Chuanhua Han
2019-07-10 13:16 ` [U-Boot] [PATCH v4 2/4] gpio: do not include <asm/arch/gpio.h> on ARCH_LS1028A Chuanhua Han
2019-07-12 11:48   ` Alex Marginean
2019-08-22  8:33     ` Prabhakar Kushwaha
2019-07-10 13:16 ` [U-Boot] [PATCH v4 3/4] configs: ls1028a: enable DM support for pcf2127 rtc Chuanhua Han
2019-07-12 11:48   ` Alex Marginean
2019-07-10 13:16 ` [U-Boot] [PATCH v4 4/4] armv8: dts: ls1028ardb: Add slave nodes under the i2c0 controller Chuanhua Han
2019-07-12 11:49   ` Alex Marginean
2019-08-22  8:33     ` Prabhakar Kushwaha
2019-08-22  8:33   ` Prabhakar Kushwaha
2019-07-12 11:46 ` Alex Marginean [this message]
2019-08-22  8:33   ` [U-Boot] [PATCH v4 1/4] armv8: ls1028a: The ls1028a platform supports the I2C driver model Prabhakar Kushwaha

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1eab499d-234a-4db3-724e-22d318778a94@gmail.com \
    --to=alexm.osslist@gmail.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox