From: Quentin Schulz <quentin.schulz@cherry.de>
To: Jonas Karlman <jonas@kwiboo.se>, Yao Zi <ziyao@disroot.org>
Cc: Simon Glass <sjg@chromium.org>,
Philipp Tomsich <philipp.tomsich@vrull.eu>,
Kever Yang <kever.yang@rock-chips.com>,
Tom Rini <trini@konsulko.com>, Sumit Garg <sumit.garg@kernel.org>,
Heiko Stuebner <heiko@sntech.de>,
"u-boot@lists.denx.de" <u-boot@lists.denx.de>
Subject: Re: [PATCH 2/2] board: rockchip: Add FriendlyElec NanoPi Zero2
Date: Mon, 20 Oct 2025 19:02:23 +0200 [thread overview]
Message-ID: <1eb9da8c-4eaa-4aa6-b13b-4790e4d0bc04@cherry.de> (raw)
In-Reply-To: <55af1d20-4dd0-4b77-8cab-035921c405a0@kwiboo.se>
Hi Jonas,
On 10/19/25 12:52 PM, Jonas Karlman wrote:
> Hi Yao Zi,
>
> On 10/19/2025 7:26 AM, Yao Zi wrote:
[...]
>> +CONFIG_DM_REGULATOR_GPIO=y
>> +CONFIG_PWM_ROCKCHIP=y
>> +CONFIG_BAUDRATE=1500000
>> +CONFIG_DEBUG_UART_SHIFT=2
>> +CONFIG_SYS_NS16550_MEM32=y
>
> Please add following to prepare for future USB support:
>
I don't like this. Whatever is enabled in the defconfig, I'm expecting
it to work when I'm testing, so I would rather suggest to postpone this
to when it actually works?
In the end, I don't own the device nor do I plan to, so whatever floats
your boat :)
Cheers,
Quentin
next prev parent reply other threads:[~2025-10-20 17:02 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-19 5:26 [PATCH 0/2] Add support for FriendlyElec NanoPi Zero2 board Yao Zi
2025-10-19 5:26 ` [PATCH 1/2] arm64: dts: rockchip: Add FriendlyElec NanoPi Zero2 Yao Zi
2025-10-19 5:26 ` [PATCH 2/2] board: " Yao Zi
2025-10-19 10:52 ` Jonas Karlman
2025-10-20 2:27 ` Yao Zi
2026-01-09 1:26 ` Jonas Karlman
2026-01-09 5:59 ` Yao Zi
2025-10-20 17:02 ` Quentin Schulz [this message]
2025-10-20 18:03 ` Jonas Karlman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1eb9da8c-4eaa-4aa6-b13b-4790e4d0bc04@cherry.de \
--to=quentin.schulz@cherry.de \
--cc=heiko@sntech.de \
--cc=jonas@kwiboo.se \
--cc=kever.yang@rock-chips.com \
--cc=philipp.tomsich@vrull.eu \
--cc=sjg@chromium.org \
--cc=sumit.garg@kernel.org \
--cc=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
--cc=ziyao@disroot.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox