From: "Maxim M. Moskalets" <maximmosk4@gmail.com>
To: Tom Rini <trini@konsulko.com>
Cc: u-boot@lists.denx.de, Maxim Moskalets <Maxim.Moskalets@kaspersky.com>
Subject: Re: [PATCH v4] cmd: add FDT setup for bootelf by flag
Date: Thu, 7 Mar 2024 22:35:35 +0300 [thread overview]
Message-ID: <1fbcf398-ee89-49b3-b514-1c36b6ee04ec@gmail.com> (raw)
In-Reply-To: <20240307124126.GA4077069@bill-the-cat>
On 07.03.2024 15:41, Tom Rini wrote:
> On Mon, Feb 26, 2024 at 09:35:53PM +0300, Maxim Moskalets wrote:
>
>> From: Maxim Moskalets <maximmosk4@gmail.com>
>>
>> Added the ability to use FDT for ELF applications, required to run some
>> OS. To make FDT setup, you need to set the -d fdt_addr_r cmd option for
>> bootelf command.
>>
>> Signed-off-by: Maxim Moskalets <Maxim.Moskalets@kaspersky.com>
>>
>> Cc: Tom Rini <trini@konsulko.com>
>> ---
>> cmd/elf.c | 27 ++++++++++++++++++++++++---
>> 1 file changed, 24 insertions(+), 3 deletions(-)
> This breaks building on a number of platforms such as
> xilinx_zynqmp_mini_nand_single.
>
There's an unresolved reference to LMB functions. This code compiles
without a patch (i.e. it is not disabled by the preprocessor or externally),
but when linking, since this function is not called, it is discarded
(you can check on a clean build with the command
aarch64-linux-gnu-objdump -d u-boot | grep image_setup_libfdt).
I think it's worth fixing this bug too.
next prev parent reply other threads:[~2024-03-07 19:35 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-26 18:35 [PATCH v4] cmd: add FDT setup for bootelf by flag Maxim Moskalets
2024-02-29 19:44 ` Maxim M. Moskalets
2024-03-07 12:41 ` Tom Rini
2024-03-07 19:35 ` Maxim M. Moskalets [this message]
2024-03-07 20:26 ` Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1fbcf398-ee89-49b3-b514-1c36b6ee04ec@gmail.com \
--to=maximmosk4@gmail.com \
--cc=Maxim.Moskalets@kaspersky.com \
--cc=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox