From: Robert Schwebel <r.schwebel@pengutronix.de>
To: u-boot@lists.denx.de
Subject: [U-Boot-Users] I2C Initialization
Date: Thu, 6 Mar 2003 09:40:06 +0100 [thread overview]
Message-ID: <20030306084006.GZ16290@pengutronix.de> (raw)
In-Reply-To: <20030306080153.C0832C6E0C@atlas.denx.de>
On Thu, Mar 06, 2003 at 09:01:48AM +0100, Wolfgang Denk wrote:
> I don't understand the problem. i2c_init() is the first I2C related
> function that will be called on any system.
>
> It is implemented in common/soft_i2c.c for the itbanging version and
> in cpu/??/i2c.c and cpu/mpc824x/drivers/i2c/i2c1.c for the others.
>
>
> What prevents you from adding it there?
>
> I don't want to add even more code to the init functions part. Let's
> keep the stuff as local as possible.
Do we agree that i2c_init_board() has to be called right before (or at
the beginning of) i2c_init()? So we have the choice to either add the
call to all 12 cpu implementations or only once in the place right
before i2c_init() is called. Why make it cpu dependend when it is not?
Robert
--
Dipl.-Ing. Robert Schwebel | http://www.pengutronix.de
Pengutronix - Linux Solutions for Science and Industry
Braunschweiger Str. 79, 31134 Hildesheim, Germany
Handelsregister: Amtsgericht Hildesheim, HRA 2686
Phone: +49-5121-28619-0 | Fax: +49-5121-28619-4
next prev parent reply other threads:[~2003-03-06 8:40 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-03-04 13:24 [U-Boot-Users] Board init Robert Schwebel
2003-03-04 15:27 ` Wolfgang Denk
2003-03-04 15:57 ` Robert Schwebel
2003-03-05 2:20 ` Adam Bezanson
2003-03-05 5:42 ` [U-Boot-Users] I2C Initialization Reinhard Meyer
2003-03-05 8:15 ` Wolfgang Denk
2003-03-05 13:05 ` Adam Bezanson
2003-03-05 14:44 ` Robert Schwebel
2003-03-05 17:39 ` Robert Schwebel
2003-03-05 19:12 ` Wolfgang Denk
2003-03-06 6:21 ` Robert Schwebel
2003-03-06 8:01 ` Wolfgang Denk
2003-03-06 8:40 ` Robert Schwebel [this message]
2003-03-06 9:24 ` Wolfgang Denk
2003-03-06 9:47 ` Robert Schwebel
2003-03-12 8:31 ` Joakim Tjernlund
2003-03-12 8:43 ` Robert Schwebel
2003-03-12 10:24 ` Joakim Tjernlund
2003-03-14 13:38 ` [U-Boot-Users] I2C Initialization, important Update!! Joakim Tjernlund
2003-03-14 14:08 ` Wolfgang Denk
2003-03-14 14:29 ` Joakim Tjernlund
2003-03-05 8:10 ` [U-Boot-Users] Board init Wolfgang Denk
2003-03-05 8:12 ` Robert Schwebel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030306084006.GZ16290@pengutronix.de \
--to=r.schwebel@pengutronix.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox