From mboxrd@z Thu Jan 1 00:00:00 1970 From: Robert Schwebel Date: Fri, 7 Mar 2003 07:29:51 +0100 Subject: [U-Boot-Users] Enforcement of coding standards In-Reply-To: References: Message-ID: <20030307062951.GD16290@pengutronix.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Thu, Mar 06, 2003 at 04:16:30PM -0000, Chris Elston wrote: > I don't really want to get into the politics of when patches should be > accepted/rejected, but I do agree that we need to have an honest (and > friendly!) discussion of the #ifdef mess and coding standard enforcement > issues. Strong ack. > Both Robert and Wolfgang have fair points. From Robert's point of view why > be picky about formatting when the rest of the source isn't as neat as it > could be. And from Wolfgang's point of view, why add more messy code - that > will just make things worse. No, the point was that these two // have been rejected, after lots of coding style patches I've sent have also been rejected because "they do not change functionality". Just for the record, I wanted to shut up about that :-) Robert -- Dipl.-Ing. Robert Schwebel | http://www.pengutronix.de Pengutronix - Linux Solutions for Science and Industry Braunschweiger Str. 79, 31134 Hildesheim, Germany Handelsregister: Amtsgericht Hildesheim, HRA 2686 Phone: +49-5121-28619-0 | Fax: +49-5121-28619-4