public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Wolfgang Denk <wd@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot-Users] [PATCH] 5/5: progress
Date: Mon, 31 Mar 2003 12:17:06 +0200	[thread overview]
Message-ID: <20030331101711.99559C587C@atlas.denx.de> (raw)
In-Reply-To: Your message of "Mon, 31 Mar 2003 11:35:02 +0200." <20030331093502.GP7702@pengutronix.de>

In message <20030331093502.GP7702@pengutronix.de> you wrote:
> 
> - fix BOOT_PROGRESS in armlinux.c
> - cosmetic changes (must be allowed as I've touched the file anyway :^)

Nothing "must" be allowed. I even allow myself to change my own
opinion ;-)


> @@ -88,7 +95,6 @@
>       */
>      if (argc >= 3) {
>  	SHOW_BOOT_PROGRESS (9);
> -
>  	addr = simple_strtoul(argv[2], NULL, 16);
>  
>  	printf ("## Loading Ramdisk Image at %08lx ...\n", addr);

Willignore this change.

> @@ -98,7 +104,7 @@
>  
>  	if (ntohl(hdr->ih_magic) != IH_MAGIC) {
>  	    printf ("Bad Magic Number\n");
> -	    SHOW_BOOT_PROGRESS (-10);
> +            SHOW_BOOT_PROGRESS (-10);
>  	    do_reset (cmdtp, flag, argc, argv);
>  	}

I will ignore this one, too.

> @@ -235,7 +235,7 @@
>  static void setup_start_tag(bd_t *bd)
>  {
>      params = (struct tag *)bd->bi_boot_params;
> -
> +    
>      params->hdr.tag = ATAG_CORE;
>      params->hdr.size = tag_size(tag_core);

And, as I have told you about 10  times  before,  I  will  definitely
ignore all patches that add trailing white space.


Best regards,

Wolfgang Denk

-- 
Software Engineering:  Embedded and Realtime Systems,  Embedded Linux
Phone: (+49)-8142-4596-87  Fax: (+49)-8142-4596-88  Email: wd at denx.de
Well, the way I see it, logic is only a way of being ignorant by num-
bers.                                 - Terry Pratchett, _Small Gods_

  reply	other threads:[~2003-03-31 10:17 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-03-31  9:35 [U-Boot-Users] [PATCH] 5/5: progress Robert Schwebel
2003-03-31 10:17 ` Wolfgang Denk [this message]
2003-03-31 10:37   ` Robert Schwebel
2003-03-31 17:43 ` Wolfgang Denk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20030331101711.99559C587C@atlas.denx.de \
    --to=wd@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox