From mboxrd@z Thu Jan  1 00:00:00 1970
From: Robert Schwebel <r.schwebel@pengutronix.de>
Date: Mon, 31 Mar 2003 17:03:55 +0200
Subject: [U-Boot-Users] [PATCH] 1/5: cmd_boot
In-Reply-To: <20030331144737.38C11C587C@atlas.denx.de>
References: <20030331141607.GI7702@pengutronix.de> <20030331144737.38C11C587C@atlas.denx.de>
Message-ID: <20030331150355.GK7702@pengutronix.de>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

On Mon, Mar 31, 2003 at 04:47:32PM +0200, Wolfgang Denk wrote:
> You patch does not delete code, but  it  adds  code,  increasing  the
> size:

We are talking about this piece of code, right? 

> +
> +	/*
> +	 * Gather any trailing characters (for instance, the ^D which
> +	 * is sent by 'cu' after sending a file), and give the
> +	 * box some time (100 * 1 ms)
> +	 */
> +	for (i=0; i<100; ++i) {
> +		if (serial_tstc()) {
> +			(void) serial_getc();
> +		}
> +		udelay(1000);
> +	}
> +

Exactly this code sniplet was located directly after the call to
load_serial_bin() in cmd_boot.c:do_load_serial_bin() before I started
looking for the problems. When I sent my first patch which _removed_
this code I somehow forgot to send you the hunk which adds it at the
right place. So this patch does not add new code, it only re-adds the
hunk which was removed instead of re-located to the right place.

Before: 
	load_serial_bin();
		download via kermit
		say "I'm finished"
	throw away garbage characters
	go on

Now: 
	load_serial_bin();
		download via kermit
		throw away garbage characters
		say "I'm finished"
	go on. 

I hope you understand what I mean... 

Robert
-- 
 Dipl.-Ing. Robert Schwebel | http://www.pengutronix.de
 Pengutronix - Linux Solutions for Science and Industry
   Braunschweiger Str. 79,  31134 Hildesheim, Germany
   Handelsregister:  Amtsgericht Hildesheim, HRA 2686
    Phone: +49-5121-28619-0 |  Fax: +49-5121-28619-4