* [U-Boot-Users] [PATCH 5/6] commonspartan
@ 2003-12-15 18:50 Robert Schwebel
2004-01-03 20:26 ` Wolfgang Denk
0 siblings, 1 reply; 2+ messages in thread
From: Robert Schwebel @ 2003-12-15 18:50 UTC (permalink / raw)
To: u-boot
-------------- next part --------------
#
# Patch managed by http://www.mn-logistik.de/unsupported/pxa250/patcher
#
--- u-boot-patches/common/spartan2.c~commonspartan 2003-07-24 16:59:42.000000000 +0200
+++ u-boot-patches/common/spartan2.c 2003-12-09 08:52:06.000000000 +0100
@@ -516,7 +516,7 @@
(*fn->clk) (FALSE, TRUE, cookie);
CONFIG_FPGA_DELAY ();
/* Write data */
- (*fn->wr) ((val < 0), TRUE, cookie);
+ (*fn->wr) ((val & 0x80), TRUE, cookie);
CONFIG_FPGA_DELAY ();
/* Assert the clock */
(*fn->clk) (TRUE, TRUE, cookie);
^ permalink raw reply [flat|nested] 2+ messages in thread
* [U-Boot-Users] [PATCH 5/6] commonspartan
2003-12-15 18:50 [U-Boot-Users] [PATCH 5/6] commonspartan Robert Schwebel
@ 2004-01-03 20:26 ` Wolfgang Denk
0 siblings, 0 replies; 2+ messages in thread
From: Wolfgang Denk @ 2004-01-03 20:26 UTC (permalink / raw)
To: u-boot
In message <20031215185046.GD10680@pengutronix.de> you wrote:
>
> --- u-boot-patches/common/spartan2.c~commonspartan 2003-07-24 16:59:42.000000000 +0200
> +++ u-boot-patches/common/spartan2.c 2003-12-09 08:52:06.000000000 +0100
> @@ -516,7 +516,7 @@
> (*fn->clk) (FALSE, TRUE, cookie);
> CONFIG_FPGA_DELAY ();
> /* Write data */
> - (*fn->wr) ((val < 0), TRUE, cookie);
> + (*fn->wr) ((val & 0x80), TRUE, cookie);
> CONFIG_FPGA_DELAY ();
> /* Assert the clock */
> (*fn->clk) (TRUE, TRUE, cookie);
>
Please explain why you think this patch is needed, i. e. which
problem it fixes. At least provide a CHANGELOG entry.
Rejected.
Wolfgang Denk
--
Software Engineering: Embedded and Realtime Systems, Embedded Linux
Phone: (+49)-8142-4596-87 Fax: (+49)-8142-4596-88 Email: wd at denx.de
"The two most common things in the universe are hydrogen and stupi-
dity."
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2004-01-03 20:26 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2003-12-15 18:50 [U-Boot-Users] [PATCH 5/6] commonspartan Robert Schwebel
2004-01-03 20:26 ` Wolfgang Denk
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox