From: Wolfgang Denk <wd@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot-Users] RTC for MPC5200
Date: Thu, 15 Jan 2004 12:00:20 +0100 [thread overview]
Message-ID: <20040115110025.46CFCC10AF@atlas.denx.de> (raw)
In-Reply-To: Your message of "Thu, 15 Jan 2004 11:22:53 +0100." <06cc01c3db51$e2f496e0$6d4ba8c0@alb.sub.de>
In message <06cc01c3db51$e2f496e0$6d4ba8c0@alb.sub.de> you wrote:
>
> > Added (as rtc/5xxx.c).
Actually it's rtc/mpc5xxx
> I do not understand the logic behind this filename. Are all 5xxx having this
> type of RTC?
> MGT5100 ? MPC5200 ? MCF5xxx (Coldfire) ??? MPC5500-Series ?
At least MGT5100 and MPC5200.
I was mostly following the agreed-on naming conventions of the Linux
kernel, where most files were named mpc5xxx...
> So at least a filename like mpc5xxx.c would be better... Currently it
Actually this is what I used.
OTOH in Linux there is arch/ppc/5xxx_io, too ;-)
> supports only the MPC5200 and nothing else
MGT5100?
> 1. these instructions were meant for Victor Wren, who had asked for MPC5200
> RTC support
You sent it to the public mailing list. It was 5 minutes of extra
work to prepare a proper patch.
I _had_ to complain because ther eis some tendency to drop arbitray
source files to the list with just laconic comments "this is what I
am using - feel free to try it - it's sink or swim."
There are documented rules, and they should be followed.
> 2. the patch for Makefile would not have worked when you rename the file
This is my internal problem, and I have tools to deal with that.
> 3. can a patch produce a new file in CVS? If yes, how?
Of course it can. See the documentation in the README (and/or read in
the diff man page about the "-N" option).
Best regards,
Wolfgang Denk
--
See us @ Embedded World, Nuremberg, Feb 17 - 19, Hall 12.0 Booth 440
Phone: (+49)-8142-4596-87 Fax: (+49)-8142-4596-88 Email: wd at denx.de
Our way is peace.
-- Septimus, the Son Worshiper, "Bread and Circuses",
stardate 4040.7.
next prev parent reply other threads:[~2004-01-15 11:00 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-01-08 21:05 [U-Boot-Users] RTC for MPC5200 Victor Wren
2004-01-08 22:56 ` Wolfgang Denk
2004-01-09 0:23 ` Victor Wren
2004-01-09 6:46 ` Wolfgang Denk
2004-01-09 16:51 ` Reinhard Meyer
2004-01-09 20:11 ` Reinhard Meyer
2004-01-15 9:18 ` Wolfgang Denk
2004-01-15 10:22 ` Reinhard Meyer
2004-01-15 11:00 ` Wolfgang Denk [this message]
2004-01-15 12:58 ` Reinhard Meyer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040115110025.46CFCC10AF@atlas.denx.de \
--to=wd@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox