[U-Boot-Users] request for comments

[Wolfgang Denk <wd@denx.de>]

In message <20040217162255.23793c83.fryman@cc.gatech.edu> you wrote:
> > Are these indeed platform independend files  that  can  go  into  the
> > common  directory?  My  suspicion is that these might be in fact very
> > board-specific features that should go into your own board  directory
> > instead.
> 
> it's kind of hard to say.  i see the lcdon/off, bkon/off much like the
> "erase" command.  it's more or less universal for anything that supports
> LCDs, but the actual implementation is very board specific.  kind of

I tend to disagree. U-Boot already has support for several board with
displays (LCD, TFD). None of these supports any of these commands.

> in general, that's a policy i understand and agree with.  in specific,
> though, i implemented the function when i was trying to debug why the
> drawing of the test pattern wasn't working.  directly doing a memory-
> modify and having to do the RGB565 encoding mentally was tiresome :)

Sure. Please feel free to add a LCD POST test :-)

> i guess i'm proposing that this be the only real random drawing function
> for just this purpose.  debugging the framebuffer is tedious without it.
> if you'd rather not see it, that's fine -- i can keep it sitsang specific
> as an additional patch people can apply.  i don't want to bolt in all

No. This is not what I want. I just think it makes no  sense  to  add
this  to  the  public  code  which  everybody  will get automatically
compiled in when he enables LCD support.  Please  feel  free  to  add
local  test functions as you like in your board directory, or - if of
a general nature - as part of POST.


Best regards,

Wolfgang Denk

-- 
See us @ Embedded World, Nuremberg, Feb 17 - 19,  Hall 12.0 Booth 440
Phone: (+49)-8142-4596-87  Fax: (+49)-8142-4596-88  Email: wd at denx.de
There's an old story about the person who wished his computer were as
easy to use as his telephone. That wish has come  true,  since  I  no
longer know how to use my telephone.