From: Wolfgang Denk <wd@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot-Users] Re: Patch: Support for PQ27e (8247/48/71/72) chips and MPC8272ADS board
Date: Mon, 15 Mar 2004 14:37:16 +0100 [thread overview]
Message-ID: <20040315133721.CF29FC0655@atlas.denx.de> (raw)
In-Reply-To: Your message of "Mon, 15 Mar 2004 15:25:18 +0200." <16469.44734.573362.958637@gargle.gargle.HOWL>
In message <16469.44734.573362.958637@gargle.gargle.HOWL> you wrote:
>
> No, no, it's just E-mail formatting of the excerpt after several
> replies. There is no redundant code in the patch.
You are right. Sorry for the confusion.
> This would require that, for every PQ27e-based board, it would be
> defined in the board configuration file that it's PQ27e and not just
> 8260. Then CPM_DATAONLY_SIZE can be defined conditionally on this
> definition in cpm_8260.h. I personally don't like such compile-time
> definitions because chip version can be easily detected in run-time.
The advantage of compile-time definitions is that they result in
smaller code.
> Wolfgang> PQ27E_FCC_SPECIAL_BASE vs. CPM_FCC_SPECIAL_BASE
...
> Well, the question is if it's better that the CPU-specific code will
> silently handle the differences or we'll make it the user's
> responsibility to define the difference manually. I think automatic
> handling is better but if you insist on #ifdefs, I can implement it too.
Sorry, but I can't follow.
next prev parent reply other threads:[~2004-03-15 13:37 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-02-29 19:04 [U-Boot-Users] Patch: Support for PQ27e (8247/48/71/72) chips and MPC8272ADS board Yuli Barcohen
2004-03-13 23:54 ` Wolfgang Denk
2004-03-15 9:45 ` [U-Boot-Users] " Yuli Barcohen
2004-03-15 10:07 ` Wolfgang Denk
2004-03-15 13:25 ` Yuli Barcohen
2004-03-15 13:37 ` Wolfgang Denk [this message]
2004-03-17 11:46 ` Yuli Barcohen
2004-03-17 14:15 ` Dan Malek
2004-03-17 15:12 ` Yuli Barcohen
2004-03-17 21:18 ` Wolfgang Denk
2004-03-18 8:54 ` Yuli Barcohen
2004-03-17 17:21 ` Kumar Gala
2004-03-17 17:39 ` Yuli Barcohen
2004-03-16 6:51 ` [U-Boot-Users] " Kumar Gala
2004-03-16 7:23 ` Yuli Barcohen
2004-03-16 14:37 ` Kumar Gala
2004-03-17 10:54 ` Yuli Barcohen
2004-03-17 15:03 ` Kumar Gala
2004-03-23 21:38 ` Wolfgang Denk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040315133721.CF29FC0655@atlas.denx.de \
--to=wd@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox