[U-Boot-Users] [Patch] flashh

[Robert Schwebel <r.schwebel@pengutronix.de>]

On Wed, Jun 09, 2004 at 02:21:24PM +0200, Wolfgang Denk wrote:
> > @@ -340,6 +343,9 @@
> >  #define FLASH_AMDL163T	0x00B2		/* AMD AM29DL163T (2M x 16 )			*/
> >  #define FLASH_AMDL163B	0x00B3
> >  
> > +#define FLASH_28F128K3  0x00A7		/* Intel 28F128K3  ( 128M = 8M x 16 )   */
> 
> This is IMHO wrong. The comment a few lines above reads:
> 
> 	Be careful when adding new type! Odd numbers are "bottom boot sector" types!
> 
> I don't think this is a bottom boot sector type.

It's a "all sectors are created equal" type ;) 

> > +#define FLASH_28F256K3  0x00A8		/* Intel 28F256K3  ( 256M = 16M x 16 )  */
> > +
> 
> Already included now.
> 
> Please fix and resubmit if needed.

I'm a little bit confused; I understand these numbers as internal U-Boot
identifiers, arent' they? The list has duplicate entries. And, according
to what you said above, how is this meant: 

#define FLASH_28F320J3A 0x007C          /* INTEL 28F320J3A ( 32M = 128K x  32)  */
#define FLASH_28F640J3A 0x007D          /* INTEL 28F640J3A ( 64M = 128K x  64)  */
#define FLASH_28F128J3A 0x007E          /* INTEL 28F128J3A (128M = 128K x 128)  */

These are equal sized as well but have ascending numbers. New patch is
attached. 

Robert
-- 
 Dipl.-Ing. Robert Schwebel | http://www.pengutronix.de
 Pengutronix - Linux Solutions for Science and Industry
   Handelsregister:  Amtsgericht Hildesheim, HRA 2686
     Hornemannstra?e 12,  31137 Hildesheim, Germany
    Phone: +49-5121-28619-0 |  Fax: +49-5121-28619-4
-------------- next part --------------
# 
# Author:	Robert Schwebel <r.schwebel@pengutronix.de>
# 
# Description:	Changelog Entry:
#
#		* Patch by Kai-Uwe Bloem, Robert Schwebel, 13 May 2004:
#		  Add support for Intel K3 strata flashs.	
#
# State:	2004-05-13: submitted
#
#		2004-06-10: INTEL_IDs added. WD: internal IDs have to be 
#		            even for non-bottom type flashes. 
#
#		2004-06-10: submitted
#


#
# Patch managed by http://www.mn-logistik.de/unsupported/pxa250/patcher
#

--- u-boot-maintainance/include/flash.h	2004-06-10 12:59:28.000000000 +0200
+++ u-boot-maintainance-ptx/include/flash.h	2004-06-10 16:21:09.000000000 +0200
@@ -364,11 +364,11 @@
 #define FLASH_AMLV256U	0x00AA		/* AMD 29LV256M	   ( 256M = 16M x 16 )	*/
 #define FLASH_MXLV320B  0x00AB		/* MX  29LV320MB   ( 32M = 2M x 16 )	*/
 #define FLASH_MXLV320T	0x00AC		/* MX  29LV320MT   ( 32M = 2M x 16 )	*/
-/* Intel 28F256L18T 256M = 128K x 255 + 32k x 4	*/
-#define FLASH_28F256L18T 0x00B0
-#define FLASH_28F256K3	0x00A8
+#define FLASH_28F256L18T 0x00B0		/* Intel 28F256L18T 256M = 128K x 255 + 32k x 4 */
 #define FLASH_AMDL163T	0x00B2		/* AMD AM29DL163T (2M x 16 )			*/
 #define FLASH_AMDL163B	0x00B3
+#define FLASH_28F128K3	0x00B6		/* Intel 28F128K3  ( 128M = 8M x 16 )   */
+#define FLASH_28F256K3	0x00B8		/* Intel 28F256K3  ( 256M = 16M x 16 )  */
 
 #define FLASH_FUJLV650	0x00B4		/* Fujitsu MBM 29LV650UE/651UE		*/