public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Marc Leeman <marc.leeman@barco.com>
To: u-boot@lists.denx.de
Subject: [U-Boot-Users] [patch] corrected comments in cpu_init
Date: Fri, 23 Jul 2004 10:32:09 +0200	[thread overview]
Message-ID: <20040723083209.GC22240@smtp.barco.com> (raw)

The comments in the cpu_init file (concerning the PCI memory accesses)
are corrected (the PPC is _slave_ instead of _master_). In our case, the
DSP is the _master_ and read/writes to the PPC memory over PCI.

-------------- next part --------------
--- u-boot-orig/cpu/mpc824x/cpu_init.c	2004-07-23 10:22:05.000000000 +0200
+++ u-boot/cpu/mpc824x/cpu_init.c	2004-07-23 10:25:04.000000000 +0200
@@ -108,7 +108,7 @@
 
 	CONFIG_READ_BYTE(PCMBCR,val);
 	/* in order not to corrupt data which is being read over the PCI bus
-	* with the PPC as master, we need to reduce the number of PCMRBs to 1,
+	* with the PPC as slave, we need to reduce the number of PCMRBs to 1,
 	* 4.11 in the  processor user manual
 	* */
 
@@ -117,6 +117,10 @@
 #else
 	CONFIG_WRITE_BYTE(PCMBCR,(val|0x80)); /* 2 PCMRBs */
 	CONFIG_WRITE_BYTE(PCMBCR,(val|0x40)); /* 3 PCMRBs */
+	/* default, 4 PCMRBs are used, so don't change the 
+	 * register is this is _really_ what you want: data
+	 * corruption with no performance gain
+	 */
 #endif
 #endif
 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
Url : http://lists.denx.de/pipermail/u-boot/attachments/20040723/00d428fb/attachment.pgp 

             reply	other threads:[~2004-07-23  8:32 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-07-23  8:32 Marc Leeman [this message]
2004-08-01 17:55 ` [U-Boot-Users] [patch] corrected comments in cpu_init Wolfgang Denk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20040723083209.GC22240@smtp.barco.com \
    --to=marc.leeman@barco.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox