From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marc Leeman Date: Fri, 23 Jul 2004 10:32:09 +0200 Subject: [U-Boot-Users] [patch] corrected comments in cpu_init Message-ID: <20040723083209.GC22240@smtp.barco.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de The comments in the cpu_init file (concerning the PCI memory accesses) are corrected (the PPC is _slave_ instead of _master_). In our case, the DSP is the _master_ and read/writes to the PPC memory over PCI. -------------- next part -------------- --- u-boot-orig/cpu/mpc824x/cpu_init.c 2004-07-23 10:22:05.000000000 +0200 +++ u-boot/cpu/mpc824x/cpu_init.c 2004-07-23 10:25:04.000000000 +0200 @@ -108,7 +108,7 @@ CONFIG_READ_BYTE(PCMBCR,val); /* in order not to corrupt data which is being read over the PCI bus - * with the PPC as master, we need to reduce the number of PCMRBs to 1, + * with the PPC as slave, we need to reduce the number of PCMRBs to 1, * 4.11 in the processor user manual * */ @@ -117,6 +117,10 @@ #else CONFIG_WRITE_BYTE(PCMBCR,(val|0x80)); /* 2 PCMRBs */ CONFIG_WRITE_BYTE(PCMBCR,(val|0x40)); /* 3 PCMRBs */ + /* default, 4 PCMRBs are used, so don't change the + * register is this is _really_ what you want: data + * corruption with no performance gain + */ #endif #endif -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 189 bytes Desc: Digital signature Url : http://lists.denx.de/pipermail/u-boot/attachments/20040723/00d428fb/attachment.pgp