[U-Boot-Users] [PATCH] test command bug.

[U-Boot-Users] [PATCH] test command bug.

[Hiroshi Ito]

Hello, I'm new to this list.

u-boot-1.1.2 ( cvs version )
# if test -z "" ; then echo true; else echo false; fi
false
# if test -n "" ; then echo true; else echo false; fi
true
#

The logic is reversed.

patch is attached.
--------
Hiroshi Ito
Media Lab. Inc.,
URL http://www.mlb.co.jp ( Sorry, Japanese only. )
TEL +81-3-5294-7255  FAX +81-3-5294-7256
-------------- next part --------------
Index: common/command.c
===================================================================
RCS file: /cvsroot/u-boot/u-boot/common/command.c,v
retrieving revision 1.17
diff -u -b -B -w -p -r1.17 command.c
--- common/command.c	18 Apr 2004 17:39:39 -0000	1.17
+++ common/command.c	26 Nov 2004 12:06:12 -0000
@@ -136,9 +136,9 @@ do_test (cmd_tbl_t *cmdtp, int flag, int
 
 		if (adv == 2) {
 			if (strcmp(ap[0], "-z") == 0)
-				expr = strlen(ap[1]) == 0 ? 0 : 1;
-			else if (strcmp(ap[0], "-n") == 0)
 				expr = strlen(ap[1]) == 0 ? 1 : 0;
+			else if (strcmp(ap[0], "-n") == 0)
+				expr = strlen(ap[1]) == 0 ? 0 : 1;
 			else {
 				expr = 1;
 				break;

[U-Boot-Users] [PATCH] test command bug.

[Wolfgang Denk]

In message <20041126210951T.ito@mlb.co.jp> you wrote:
>
> Hello, I'm new to this list.
> 
> u-boot-1.1.2 ( cvs version )
> # if test -z "" ; then echo true; else echo false; fi
> false
> # if test -n "" ; then echo true; else echo false; fi
> true
> #
> 
> The logic is reversed.
> 
> patch is attached.

Good introduction :-) Thanks, added. [Sorry it took so long.]

Best regards,

Wolfgang Denk

-- 
Software Engineering:  Embedded and Realtime Systems,  Embedded Linux
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
The idea of male and female are universal constants.
	-- Kirk, "Metamorphosis", stardate 3219.8