From: Ladislav Michl <ladis@linux-mips.org>
To: u-boot@lists.denx.de
Subject: [U-Boot-Users] [PATCH] fix flinfo formatting for CFI flash
Date: Sat, 26 Feb 2005 12:00:00 +0100 [thread overview]
Message-ID: <20050226110000.GB10884@orphique> (raw)
Hi,
flinfo is currently outputs this with CFG_FLASH_EMPTY_INFO defined:
Bank # 1: CFI conformant FLASH (16 x 16) Size: 4 MB in 71 Sectors
Erase timeout 16384 ms, write timeout 0 ms, buffer write timeout 1 ms, buffer size 1
Sector Start Addresses:
00000000 RO 00002000 RO 00004000 RO 00006000 RO 00008000 RO
0000A000 RO 0000C000 RO 0000E000 RO 00010000 RO 00020000 ERO
00030000 ERO 00040000 00050000 00060000 00070000
00080000 00090000 000A0000 000B0000 000C0000
and this with CFG_FLASH_EMPTY_INFO undefined:
Bank # 1: CFI conformant FLASH (16 x 16) Size: 4 MB in 71 Sectors
Erase timeout 16384 ms, write timeout 0 ms, buffer write timeout 1 ms, buffer size 1
Sector Start Addresses:
00000000 (RO) 00002000 (RO) 00004000 (RO) 00006000 (RO) 00008000 (RO)
0000A000 (RO) 0000C000 (RO) 0000E000 (RO) 00010000 (RO) 00020000 (RO)
00030000 (RO) 00040000 00050000 00060000 00070000
00080000 00090000 000A0000 000B0000 000C0000
Patch below fixes flinfo with CFG_FLASH_EMPTY_INFO undefined to print
informations as follows, making it similar with 1st case above
Bank # 1: CFI conformant FLASH (16 x 16) Size: 4 MB in 71 Sectors
Erase timeout 16384 ms, write timeout 0 ms, buffer write timeout 1 ms, buffer size 1
Sector Start Addresses:
00000000 RO 00002000 RO 00004000 RO 00006000 RO 00008000 RO
0000A000 RO 0000C000 RO 0000E000 RO 00010000 RO 00020000 RO
00030000 00040000 00050000 00060000 00070000
00080000 00090000 000A0000 000B0000 000C0000
Similar fix is contained in Michael Bendzick's patch, Message-ID:
<31ADFA827355984B9E2A161514595B561C34C2@lpdsrv04.logicpd.com> from
Fri, 14 Jan 2005 14:55:36 -0600, but I think this formatting is more
consistent with flash empty info version.
CHANGELOG:
* Patch by Ladislav Michl, 26 Feb 2005:
- fix flinfo formatting for CFI flash
Index: drivers/cfi_flash.c
===================================================================
RCS file: /cvsroot/u-boot/u-boot/drivers/cfi_flash.c,v
retrieving revision 1.16
diff -u -r1.16 cfi_flash.c
--- drivers/cfi_flash.c 9 Jan 2005 17:12:33 -0000 1.16
+++ drivers/cfi_flash.c 26 Feb 2005 10:23:06 -0000
@@ -483,7 +482,7 @@
if ((i % 5) == 0)
printf ("\n ");
printf (" %08lX%s",
- info->start[i], info->protect[i] ? " (RO) " : " ");
+ info->start[i], info->protect[i] ? " RO " : " ");
#endif
}
putc ('\n');
reply other threads:[~2005-02-26 11:00 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050226110000.GB10884@orphique \
--to=ladis@linux-mips.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox