From mboxrd@z Thu Jan  1 00:00:00 1970
From: Wolfgang Denk <wd@denx.de>
Date: Thu, 18 Aug 2005 22:41:52 +0200
Subject: [U-Boot-Users] [Patch] KVME080 Support 
In-Reply-To: Your message of "Thu, 18 Aug 2005 18:57:13 +0900."
             <004e01c5a3db$3840e6f0$212d4cdc@smkim> 
Message-ID: <20050818204152.36097353CE9@atlas.denx.de>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

In message <004e01c5a3db$3840e6f0$212d4cdc@smkim> you wrote:
>
> This patch adds support for KVME080 board.
> KVME080 is a VME board with MPC8245 CPU.
> 
> It also patches drivers/cfi_flash.c.

Can you please split your patch into two?

Please  see  section  "Submitting  Patches"  in  the   README   which
explicitely requires:

        Changesets that contain different, unrelated modifications
        shall be submitted as SEPARATE patches, one patch per
        changeset.


And please cleanup your code before re-submitting:

* It violates the coding style requirements (trailing white space).

* Using globally visible preprocessor defines like  FLASH_WRITE64  is
  not  acceptable  (you also forgot to document these, but that would
  help either), and defining such code in the board  config  file  is
  the  wrong  way  to implement it either. The board config file is -
  ummm, a _configuration_ file, but does not contain source code.


Also:  please  read  the  recent  "U-Boot  Developer's   Information"
posting;  you  are  supposed  to  provide  a  "sign-off" line for all
patches.

Rejected, sorry.

Best regards,

Wolfgang Denk

-- 
Software Engineering:  Embedded and Realtime Systems,  Embedded Linux
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
One friend in a lifetime is much; two  are  many;  three  are  hardly
possible. Friendship needs a certain parallelism of life, a community
of thought, a rivalry of aim.                     - Henry Brook Adams