From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ladislav Michl Date: Tue, 13 Sep 2005 18:31:14 +0200 Subject: [U-Boot-Users] PATCH for cmd_mem.c:do_mem_mtest() In-Reply-To: <20050913161856.03D1B352B8B@atlas.denx.de> References: <20050913161856.03D1B352B8B@atlas.denx.de> Message-ID: <20050913163114.GA19366@orphique> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Tue, Sep 13, 2005 at 06:18:56PM +0200, Wolfgang Denk wrote: > > ChangeLog: > > * Patch by Andrew Dyer, 13 September 2005: > > if CFG_ALT_MEMTEST is defined without > > CFG_MEMTEST_SCRATCH, cmd_mem.c > > code will dereference a null pointer. Change > > No, it does not. It just points to address 0x0000. This is a > perfectly valid address on many systems. I sent patch to mailing list few months ago which changes NULL to 0x00000000 and adds some comment to avoid such confusion (I burned my fingers the same way :-)). ftp://ftp.linux-mips.org/pub/linux/mips/people/ladis/u-boot/cmd_mem_dummy_addr.diff Best regards, ladis