From: luo.jinhua <luo.jinhua@gd-linux.com>
To: u-boot@lists.denx.de
Subject: [U-Boot-Users] My 3 patches
Date: Wed, 21 Sep 2005 17:18:47 +0800 [thread overview]
Message-ID: <20050920073915.M5230@gd-linux.com> (raw)
In-Reply-To: <010201c5baaa$73e26270$27050a0a@jadechip.net>
On Fri, 16 Sep 2005 18:36:09 +0800, Bryan Wu wrote
> Hi:
>
> I applied your patch my U-Boot. But I found one bug in this patch
> in cread_line() function, you should return the number of read characters.
> You return the "rc" at the end of the function, but rc always equals
> 0. The u-boot command will NOT be executed.
>
> I modified the to return (eol_num). It is ok.
>
> You can check it.
>
> Bryan Wu from China.
Thank you.
It is indeed a bug. However, while I always use CFG_HUSH_PARSER, the hush
engine ignores the "rc" retval and recalculates the console_buffer length,
which make me miss the bug.
Best regards,
luo.jinhua
----------
JinHua Luo, GuangDong Linux Center, <luo.jinhua@gd-linux.com>
next prev parent reply other threads:[~2005-09-21 9:18 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-09-02 2:02 [U-Boot-Users] My 3 patches luo.jinhua
2005-09-16 10:36 ` Bryan Wu
2005-09-21 9:18 ` luo.jinhua [this message]
2006-07-22 19:00 ` Wolfgang Denk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050920073915.M5230@gd-linux.com \
--to=luo.jinhua@gd-linux.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox