From mboxrd@z Thu Jan  1 00:00:00 1970
From: luo.jinhua <luo.jinhua@gd-linux.com>
Date: Wed, 21 Sep 2005 17:18:47 +0800
Subject: [U-Boot-Users] My 3 patches
In-Reply-To: <010201c5baaa$73e26270$27050a0a@jadechip.net>
References: <20050902010558.M5503@gd-linux.com> <010201c5baaa$73e26270$27050a0a@jadechip.net>
Message-ID: <20050920073915.M5230@gd-linux.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

On Fri, 16 Sep 2005 18:36:09 +0800, Bryan Wu wrote
> Hi:
> 
> I applied your patch my U-Boot. But I found one bug in this patch
> in cread_line() function, you should return the number of read characters.
> You return the "rc" at the end of the function, but rc always equals 
> 0. The u-boot command will NOT be executed.
> 
> I modified the to return (eol_num). It is ok.
> 
> You can check it.
> 
> Bryan Wu from China.
Thank you.

It is indeed a bug. However, while I always use CFG_HUSH_PARSER, the hush
engine ignores the "rc" retval and recalculates the console_buffer length,
which make me miss the bug.

Best regards,
 
luo.jinhua
----------
JinHua Luo, GuangDong Linux Center, <luo.jinhua@gd-linux.com>