From: Stefan Roese <sr@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot-Users] Time Base register definitions inccorrect in asm-ppc/processor.h
Date: Mon, 7 Nov 2005 10:00:30 +0100 [thread overview]
Message-ID: <200511071000.31398.sr@denx.de> (raw)
In-Reply-To: <d1ed0eb40511050943k7825e61doc125ac589fd6ab3c@mail.gmail.com>
Hi Mike,
On Saturday 05 November 2005 18:43, Mike Wellington wrote:
> In include/asm-ppc/processor.h the definitions for the
> Time Base Upper and Lower registers are incorrect for the
> PPC440GX.
>
>
> #define SPRN_TBRL 0x10D /* Time Base Read Lower Register */
> #define SPRN_TBRU 0x10C /* Time Base Read Upper Register */
> #define SPRN_TBWL 0x11D /* Time Base Write Lower Register */
> #define SPRN_TBWU 0x11C /* Time Base Write Upper Register */
>
> i fixed this in my own code by adding the following ifdef:
>
> #ifdef CONFIG_440GX
> #define SPRN_TBRL 0x10C /* Time Base Read Lower Register */
> #define SPRN_TBRU 0x10D /* Time Base Read Upper Register */
> #define SPRN_TBWL 0x11C /* Time Base Write Lower Register */
> #define SPRN_TBWU 0x11D /* Time Base Write Upper Register */
> #else
> #define SPRN_TBRL 0x10D /* Time Base Read Lower Register */
> #define SPRN_TBRU 0x10C /* Time Base Read Upper Register */
> #define SPRN_TBWL 0x11D /* Time Base Write Lower Register */
> #define SPRN_TBWU 0x11C /* Time Base Write Upper Register */
> #endif
After a quick look in some other ppc manuals (AMCC and Freescale) this seems
to be not only a 440GX problem, but a generic ppc problem. I will prepare a
patch for this.
I didn't find any code referencing these registers. Do you have an
command/application using these timebase regsisters, which could be
interesting for the community? If so, please share it it with us.
And please submit a proper patch next time (CHANGELOG, etc...)
Best regards,
Stefan
next prev parent reply other threads:[~2005-11-07 9:00 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-11-05 17:43 [U-Boot-Users] Time Base register definitions inccorrect in asm-ppc/processor.h Mike Wellington
2005-11-07 9:00 ` Stefan Roese [this message]
2005-11-07 14:43 ` Dan Malek
2005-11-25 3:22 ` Mike Wellington
2005-11-25 8:16 ` Wolfgang Denk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200511071000.31398.sr@denx.de \
--to=sr@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox