* [U-Boot-Users] [PATCH] Add target 'cscope' to Makefile
@ 2006-02-19 15:06 Horst Kronstorfer
2006-02-19 20:40 ` Wolfgang Denk
2006-02-19 20:47 ` Wolfgang Denk
0 siblings, 2 replies; 5+ messages in thread
From: Horst Kronstorfer @ 2006-02-19 15:06 UTC (permalink / raw)
To: u-boot
hi!
the following patch adds target 'cscope' to the main makefile. it also
puts the list of directories with source files and the arguments to `find'
into make variables.
Signed-off-by: Horst Kronstorfer <hkronsto@frequentis.com>
diff --git a/Makefile b/Makefile
index 9305cab..80e3677 100644
--- a/Makefile
+++ b/Makefile
@@ -135,6 +135,14 @@ SUBDIRS = tools \
post/cpu
.PHONY : $(SUBDIRS)
+# Directories with files for tag generation
+TAGDIRS := $(SUBDIRS) include lib_generic board/$(BOARDDIR) cpu/$(CPU)\
+ lib_$(ARCH) fs/cramfs fs/fat fs/fdos fs/jffs2 net disk rtc dtt drivers\
+ drivers/sk98lin common
+
+# Arguments to `find' when generating a list of files for tag generation
+TAGFINDARGS := \( -name CVS -prune \) -o \( -name '*.[ch]' -print \)
+
#########################################################################
#########################################################################
@@ -179,19 +187,14 @@ gdbtools:
depend dep:
@for dir in $(SUBDIRS) ; do $(MAKE) -C $$dir .depend ; done
+cscope:
+ find $(TAGDIRS) $(TAGFINDARGS) >cscope.files; cscope -b -q -k
+
tags:
- ctags -w `find $(SUBDIRS) include \
- lib_generic board/$(BOARDDIR) cpu/$(CPU) lib_$(ARCH) \
- fs/cramfs fs/fat fs/fdos fs/jffs2 \
- net disk rtc dtt drivers drivers/sk98lin common \
- \( -name CVS -prune \) -o \( -name '*.[ch]' -print \)`
+ ctags -w `find $(TAGDIRS) $(TAGFINDARGS)`
etags:
- etags -a `find $(SUBDIRS) include \
- lib_generic board/$(BOARDDIR) cpu/$(CPU) lib_$(ARCH) \
- fs/cramfs fs/fat fs/fdos fs/jffs2 \
- net disk rtc dtt drivers drivers/sk98lin common \
- \( -name CVS -prune \) -o \( -name '*.[ch]' -print \)`
+ etags -a `find $(TAGDIRS) $(TAGFINDARGS)`
System.map: u-boot
@$(NM) $< | \
@@ -1838,7 +1841,7 @@ clobber: clean
-o -name '*.srec' -o -name '*.bin' -o -name u-boot.img \) \
-print0 \
| xargs -0 rm -f
- rm -f $(OBJS) *.bak tags TAGS
+ rm -f $(OBJS) *.bak tags TAGS cscope.*
rm -fr *.*~
rm -f u-boot u-boot.map u-boot.hex $(ALL)
rm -f tools/crc32.c tools/environment.c tools/env/crc32.c
-h
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [U-Boot-Users] [PATCH] Add target 'cscope' to Makefile
2006-02-19 15:06 [U-Boot-Users] [PATCH] Add target 'cscope' to Makefile Horst Kronstorfer
@ 2006-02-19 20:40 ` Wolfgang Denk
2006-02-19 20:47 ` Wolfgang Denk
1 sibling, 0 replies; 5+ messages in thread
From: Wolfgang Denk @ 2006-02-19 20:40 UTC (permalink / raw)
To: u-boot
In message <20060219150640.GA3310@aquarius> you wrote:
>
> the following patch adds target 'cscope' to the main makefile. it also
> puts the list of directories with source files and the arguments to `find'
> into make variables.
Rejected. Please resubmit after including a CHANGELOG entry that
describes what you do, and why. Don't assume that everybody knows
what a "target 'cscope'" might be good for.
Best regards,
Wolfgang Denk
--
Software Engineering: Embedded and Realtime Systems, Embedded Linux
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
About the use of language: it is impossible to sharpen a pencil with
a blunt ax. It is equally vain to try to do it with ten blunt axes
instead. -- Edsger Dijkstra
^ permalink raw reply [flat|nested] 5+ messages in thread
* [U-Boot-Users] [PATCH] Add target 'cscope' to Makefile
2006-02-19 15:06 [U-Boot-Users] [PATCH] Add target 'cscope' to Makefile Horst Kronstorfer
2006-02-19 20:40 ` Wolfgang Denk
@ 2006-02-19 20:47 ` Wolfgang Denk
2006-02-19 23:34 ` Horst Kronstorfer
1 sibling, 1 reply; 5+ messages in thread
From: Wolfgang Denk @ 2006-02-19 20:47 UTC (permalink / raw)
To: u-boot
In message <20060219150640.GA3310@aquarius> you wrote:
>
> the following patch adds target 'cscope' to the main makefile. it also
> puts the list of directories with source files and the arguments to `find'
> into make variables.
On second look, I think this patch needs some more work:
> +# Directories with files for tag generation
> +TAGDIRS := $(SUBDIRS) include lib_generic board/$(BOARDDIR) cpu/$(CPU)\
> + lib_$(ARCH) fs/cramfs fs/fat fs/fdos fs/jffs2 net disk rtc dtt drivers\
> + drivers/sk98lin common
This doesn't look complete to me - for example, how about post/ ?
> +# Arguments to `find' when generating a list of files for tag generation
> +TAGFINDARGS := \( -name CVS -prune \) -o \( -name '*.[ch]' -print \)
You should probably also exclude .git directories here, just in case.
Best regards,
Wolfgang Denk
--
Software Engineering: Embedded and Realtime Systems, Embedded Linux
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"Those who will be able to conquer software will be able to conquer
the world." - Tadahiro Sekimoto, president, NEC Corp.
^ permalink raw reply [flat|nested] 5+ messages in thread
* [U-Boot-Users] [PATCH] Add target 'cscope' to Makefile
2006-02-19 20:47 ` Wolfgang Denk
@ 2006-02-19 23:34 ` Horst Kronstorfer
2006-10-11 22:00 ` Grant Likely
0 siblings, 1 reply; 5+ messages in thread
From: Horst Kronstorfer @ 2006-02-19 23:34 UTC (permalink / raw)
To: u-boot
On Sun, Feb 19, 2006 at 09:47:19PM +0100, Wolfgang Denk wrote:
> In message <20060219150640.GA3310@aquarius> you wrote:
> >
> > the following patch adds target 'cscope' to the main makefile. it also
> > puts the list of directories with source files and the arguments to `find'
> > into make variables.
>
> On second look, I think this patch needs some more work:
>
> > +# Directories with files for tag generation
> > +TAGDIRS := $(SUBDIRS) include lib_generic board/$(BOARDDIR) cpu/$(CPU)\
> > + lib_$(ARCH) fs/cramfs fs/fat fs/fdos fs/jffs2 net disk rtc dtt drivers\
> > + drivers/sk98lin common
>
> This doesn't look complete to me - for example, how about post/ ?
>
post is included in $(SUBDIRS), but you're right, some 'fs' subdirs were
missing. i should have examined it when i copied the directory list from
the 'tags'/'etags' target.
> > +# Arguments to `find' when generating a list of files for tag generation
> > +TAGFINDARGS := \( -name CVS -prune \) -o \( -name '*.[ch]' -print \)
>
> You should probably also exclude .git directories here, just in case.
>
oke. i also excluded .svn (subversion)
-h
---
Signed-off-by: Horst Kronstorfer <hkronsto@frequentis.com>
CHANGELOG
* Added target 'cscope' to the main makefile. cscope (like ctags/etags) is
a tool for browsing source code. For further information go to the cscope
website at http://cscope.sourceforge.net/. An alternative to cscope named
freescope is available at http://freescope.sourceforge.net/.
Patch by Horst Kronstorfer, 20 Feb 2006
diff --git a/Makefile b/Makefile
index 9305cab..6ccbe0c 100644
--- a/Makefile
+++ b/Makefile
@@ -135,6 +135,14 @@ SUBDIRS = tools \
post/cpu
.PHONY : $(SUBDIRS)
+# Directories with files for tag generation
+TAGDIRS := $(SUBDIRS) include lib_generic board/$(BOARDDIR) cpu/$(CPU)\
+ lib_$(ARCH) fs net disk rtc dtt drivers common
+
+# Arguments to `find' when generating a list of files for tag generation
+TAGFINDARGS := \( -name CVS -prune \) -o \( -name .git -prune \) -o\
+ \( -name .svn -prune \) -o \( -name '*.[ch]' -print \)
+
#########################################################################
#########################################################################
@@ -179,19 +187,14 @@ gdbtools:
depend dep:
@for dir in $(SUBDIRS) ; do $(MAKE) -C $$dir .depend ; done
+cscope:
+ find $(TAGDIRS) $(TAGFINDARGS) >cscope.files; cscope -b -q -k
+
tags:
- ctags -w `find $(SUBDIRS) include \
- lib_generic board/$(BOARDDIR) cpu/$(CPU) lib_$(ARCH) \
- fs/cramfs fs/fat fs/fdos fs/jffs2 \
- net disk rtc dtt drivers drivers/sk98lin common \
- \( -name CVS -prune \) -o \( -name '*.[ch]' -print \)`
+ ctags -w `find $(TAGDIRS) $(TAGFINDARGS)`
etags:
- etags -a `find $(SUBDIRS) include \
- lib_generic board/$(BOARDDIR) cpu/$(CPU) lib_$(ARCH) \
- fs/cramfs fs/fat fs/fdos fs/jffs2 \
- net disk rtc dtt drivers drivers/sk98lin common \
- \( -name CVS -prune \) -o \( -name '*.[ch]' -print \)`
+ etags -a `find $(TAGDIRS) $(TAGFINDARGS)`
System.map: u-boot
@$(NM) $< | \
@@ -1838,7 +1841,7 @@ clobber: clean
-o -name '*.srec' -o -name '*.bin' -o -name u-boot.img \) \
-print0 \
| xargs -0 rm -f
- rm -f $(OBJS) *.bak tags TAGS
+ rm -f $(OBJS) *.bak tags TAGS cscope.*
rm -fr *.*~
rm -f u-boot u-boot.map u-boot.hex $(ALL)
rm -f tools/crc32.c tools/environment.c tools/env/crc32.c
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [U-Boot-Users] [PATCH] Add target 'cscope' to Makefile
2006-02-19 23:34 ` Horst Kronstorfer
@ 2006-10-11 22:00 ` Grant Likely
0 siblings, 0 replies; 5+ messages in thread
From: Grant Likely @ 2006-10-11 22:00 UTC (permalink / raw)
To: u-boot
Wolfgang, what's the status of this patch? Does it still need work to
go into mainline?
Thanks,
g.
On 2/19/06, Horst Kronstorfer <crimm@elemaa.net> wrote:
> On Sun, Feb 19, 2006 at 09:47:19PM +0100, Wolfgang Denk wrote:
> > In message <20060219150640.GA3310@aquarius> you wrote:
> > >
> > > the following patch adds target 'cscope' to the main makefile. it also
> > > puts the list of directories with source files and the arguments to `find'
> > > into make variables.
> >
> > On second look, I think this patch needs some more work:
> >
> > > +# Directories with files for tag generation
> > > +TAGDIRS := $(SUBDIRS) include lib_generic board/$(BOARDDIR) cpu/$(CPU)\
> > > + lib_$(ARCH) fs/cramfs fs/fat fs/fdos fs/jffs2 net disk rtc dtt drivers\
> > > + drivers/sk98lin common
> >
> > This doesn't look complete to me - for example, how about post/ ?
> >
>
> post is included in $(SUBDIRS), but you're right, some 'fs' subdirs were
> missing. i should have examined it when i copied the directory list from
> the 'tags'/'etags' target.
>
> > > +# Arguments to `find' when generating a list of files for tag generation
> > > +TAGFINDARGS := \( -name CVS -prune \) -o \( -name '*.[ch]' -print \)
> >
> > You should probably also exclude .git directories here, just in case.
> >
>
> oke. i also excluded .svn (subversion)
>
> -h
>
> ---
>
> Signed-off-by: Horst Kronstorfer <hkronsto@frequentis.com>
>
> CHANGELOG
> * Added target 'cscope' to the main makefile. cscope (like ctags/etags) is
> a tool for browsing source code. For further information go to the cscope
> website at http://cscope.sourceforge.net/. An alternative to cscope named
> freescope is available at http://freescope.sourceforge.net/.
> Patch by Horst Kronstorfer, 20 Feb 2006
>
>
> diff --git a/Makefile b/Makefile
> index 9305cab..6ccbe0c 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -135,6 +135,14 @@ SUBDIRS = tools \
> post/cpu
> .PHONY : $(SUBDIRS)
>
> +# Directories with files for tag generation
> +TAGDIRS := $(SUBDIRS) include lib_generic board/$(BOARDDIR) cpu/$(CPU)\
> + lib_$(ARCH) fs net disk rtc dtt drivers common
> +
> +# Arguments to `find' when generating a list of files for tag generation
> +TAGFINDARGS := \( -name CVS -prune \) -o \( -name .git -prune \) -o\
> + \( -name .svn -prune \) -o \( -name '*.[ch]' -print \)
> +
> #########################################################################
> #########################################################################
>
> @@ -179,19 +187,14 @@ gdbtools:
> depend dep:
> @for dir in $(SUBDIRS) ; do $(MAKE) -C $$dir .depend ; done
>
> +cscope:
> + find $(TAGDIRS) $(TAGFINDARGS) >cscope.files; cscope -b -q -k
> +
> tags:
> - ctags -w `find $(SUBDIRS) include \
> - lib_generic board/$(BOARDDIR) cpu/$(CPU) lib_$(ARCH) \
> - fs/cramfs fs/fat fs/fdos fs/jffs2 \
> - net disk rtc dtt drivers drivers/sk98lin common \
> - \( -name CVS -prune \) -o \( -name '*.[ch]' -print \)`
> + ctags -w `find $(TAGDIRS) $(TAGFINDARGS)`
>
> etags:
> - etags -a `find $(SUBDIRS) include \
> - lib_generic board/$(BOARDDIR) cpu/$(CPU) lib_$(ARCH) \
> - fs/cramfs fs/fat fs/fdos fs/jffs2 \
> - net disk rtc dtt drivers drivers/sk98lin common \
> - \( -name CVS -prune \) -o \( -name '*.[ch]' -print \)`
> + etags -a `find $(TAGDIRS) $(TAGFINDARGS)`
>
> System.map: u-boot
> @$(NM) $< | \
> @@ -1838,7 +1841,7 @@ clobber: clean
> -o -name '*.srec' -o -name '*.bin' -o -name u-boot.img \) \
> -print0 \
> | xargs -0 rm -f
> - rm -f $(OBJS) *.bak tags TAGS
> + rm -f $(OBJS) *.bak tags TAGS cscope.*
> rm -fr *.*~
> rm -f u-boot u-boot.map u-boot.hex $(ALL)
> rm -f tools/crc32.c tools/environment.c tools/env/crc32.c
>
>
> -------------------------------------------------------
> This SF.net email is sponsored by: Splunk Inc. Do you grep through log files
> for problems? Stop! Download the new AJAX search engine that makes
> searching your log files as easy as surfing the web. DOWNLOAD SPLUNK!
> http://sel.as-us.falkag.net/sel?cmd=lnk&kid=103432&bid=230486&dat=121642
> _______________________________________________
> U-Boot-Users mailing list
> U-Boot-Users at lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/u-boot-users
>
--
Grant Likely, B.Sc. P.Eng.
Secret Lab Technologies Ltd.
grant.likely at secretlab.ca
(403) 399-0195
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2006-10-11 22:00 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-02-19 15:06 [U-Boot-Users] [PATCH] Add target 'cscope' to Makefile Horst Kronstorfer
2006-02-19 20:40 ` Wolfgang Denk
2006-02-19 20:47 ` Wolfgang Denk
2006-02-19 23:34 ` Horst Kronstorfer
2006-10-11 22:00 ` Grant Likely
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox