[U-Boot-Users] [PATCH] CFI support for Versatile & Integrator/CP boards

Peter Pearse
2006-02-28T11:58:58Z

Stefan Roese wrote:
> Hi Peter,

>> The patch
>> - Makes flash_get_size() static.
>
> Rejected. This function is called from other board files.

I don't mind but:-
- flash_get_size() is not declared in include/flash.h
- I don't see a board which calls flash_get_size() without providing its own
flash.c::flash_get_size(),
although not all are declared static. Arguably the board level code might
have some reason to subvert
the flash interface (?), but making it static guards against accidental
cross-linking.
- IMHO flash info should be accessed from the flash_info[] array, set up by
a call to flash_init(), keeping the
flash interface small.

>
> Please take a look at the patch from Marcus Hall:
>
> http://article.gmane.org/gmane.comp.boot-loaders.u-boot/18530
>
Yes this patch is correct, mine would give two errors....

Regards

Peter