public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Stefan Roese <sr@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot-Users] [PATCH] CFI support for Versatile & Integrator/CP boards
Date: Tue, 28 Feb 2006 10:24:13 +0100	[thread overview]
Message-ID: <200602281024.13958.sr@denx.de> (raw)
In-Reply-To: <CAM-OWA1XvpFVjCRGry00000004@cam-owa1.Emea.Arm.com>

Hi Peter,

On Monday, 27. February 2006 16:59, Peter Pearse wrote:
> The attached gzipped patch was made against the U-Boot GIT commit
> 6624b687bc2b747233090e67628df37d1c84ed17.

Thanks.

> It is a completely independent patch, containing the patches to
> drivers/cfi_flash.c
> which were in my patch 012.
>
> The patch
> - Makes flash_get_size() static.

Rejected. This function is called from other board files. I will remove this 
part of the patch.

> - Changes flash_full_status_check() to test for timeout OR failure,
>   rather than timeout AND failure.

I'm not sure here. Please take a look at the patch from Marcus Hall:

http://article.gmane.org/gmane.comp.boot-loaders.u-boot/18530

Could you and others (Marcus, Tolunay) please comment on what patch should be 
applied here. I tend to take the patch from Marcus right now.

> - Makes find_sector() available for BOTH versions of flash_write_cfiword()

Applied.

> CHANGELOG:
> 	Update drivers/cfi_flash.c.
> 	- flash_get_size() now static.
> 	- flash_full_status_check() to test for timeout OR failure,
> 	  rather than timeout AND failure.
> 	- find_sector() called in both versions of flash_write_cfiword()
> 	Patch by Peter Pearse, 27th Feb 2006
>
> I intend to re-submit the changes for the boards (Integrator/CP,
> VersatileAB & PB) separately,
> once you have completed your CFI work.

OK. Please give us a few more days and the new CFI driver should be available.

Best regards,
Stefan

  reply	other threads:[~2006-02-28  9:24 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-10-31 16:44 [U-Boot-Users] [PATCH] CFI support for Versatile & Integrator/CP boards Peter Pearse
2006-02-27 12:29 ` Stefan Roese
2006-02-27 15:59   ` Peter Pearse
2006-02-28  9:24     ` Stefan Roese [this message]
2006-02-28 11:58       ` Peter Pearse
2006-02-28 12:30         ` Stefan Roese
2006-02-28 18:46       ` Marcus Hall
2006-02-28 19:05         ` Stefan Roese
2006-02-28 19:21       ` Tolunay Orkun
2006-02-28 19:53         ` Marcus Hall
2006-02-28 20:32           ` Tolunay Orkun
2006-02-28 16:43 ` Wolfgang Denk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200602281024.13958.sr@denx.de \
    --to=sr@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox