From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stefan Roese Date: Tue, 28 Feb 2006 13:30:16 +0100 Subject: [U-Boot-Users] [PATCH] CFI support for Versatile & Integrator/CP boards In-Reply-To: References: Message-ID: <200602281330.16828.sr@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi Peter, On Tuesday, 28. February 2006 12:58, Peter Pearse wrote: > >> The patch > >> - Makes flash_get_size() static. > > > > Rejected. This function is called from other board files. > > I don't mind but:- > - flash_get_size() is not declared in include/flash.h Good point. I will fix this. > - I don't see a board which calls flash_get_size() without providing its > own flash.c::flash_get_size(), For example "board/tqm85xx/tqm85xx.c". > although not all are declared static. Arguably the board level code might > have some reason to subvert > the flash interface (?), but making it static guards against accidental > cross-linking. > - IMHO flash info should be accessed from the flash_info[] array, set up by > a call to flash_init(), keeping the > flash interface small. Generally ok, but in some cases this function is used to re-init the sector setup when not using the max. flash amount (especially on high-boot systems). > > Please take a look at the patch from Marcus Hall: > > > > http://article.gmane.org/gmane.comp.boot-loaders.u-boot/18530 > > Yes this patch is correct, mine would give two errors.... OK. Thanks. Best regards, Stefan