[U-Boot-Users] [PATCH] fix conditional for including ks8695eth driver

[U-Boot-Users] [PATCH] fix conditional for including ks8695eth driver

[Greg Ungerer]

Move the c-preprocessor conditional check for compiling the ks8695eth
driver code to after including the headers. Otherwise it can never
be compiled in.





-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: ks8695eth.patch
Url: http://lists.denx.de/pipermail/u-boot/attachments/20050604/df3b5ec0/attachment.txt 

[U-Boot-Users] [PATCH] fix conditional for including ks8695eth driver

[Wolfgang Denk]

In message <42A06968.3050706@moreton.com.au> you wrote:
>
> Move the c-preprocessor conditional check for compiling the ks8695eth
> driver code to after including the headers. Otherwise it can never
> be compiled in.

Applied. But please provide a proper CHANGELOG entry next time!

Best regards,

Wolfgang Denk

-- 
Software Engineering:  Embedded and Realtime Systems,  Embedded Linux
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
In an infinite universe all things are possible, including the possi-
bility that the universe does not exist.
                        - Terry Pratchett, _The Dark Side of the Sun_

[U-Boot-Users] [PATCH] fix conditional for including ks8695eth driver

[Wang Jian]

Hi Wolfgang Denk,

This commit breaks compile of boards without <asm/arch/platform.h>.

Example:

$ make Sandpoint8240_config; make


Relevant files

$ grep -R asm/arch/platform.h *
board/cm41xx/cm41xx.c:#include <asm/arch/platform.h>
board/cm4008/cm4008.c:#include <asm/arch/platform.h>
cpu/arm920t/ks8695/interrupts.c:#include <asm/arch/platform.h>
cpu/arm920t/ks8695/lowlevel_init.S:#include <asm/arch/platform.h>
cpu/arm920t/ks8695/serial.c:#include <asm/arch/platform.h>
drivers/ks8695eth.c:#include <asm/arch/platform.h>
grep: include/asm/arch: No such file or directory
grep: include/asm-ppc/arch: No such file or directory

$ find . -name platform.h
./include/asm-microblaze/platform.h
./include/asm-arm/arch-ks8695/platform.h


On Sun, 12 Mar 2006 01:40:36 +0100, Wolfgang Denk <wd@denx.de> wrote:

> In message <42A06968.3050706@moreton.com.au> you wrote:
> >
> > Move the c-preprocessor conditional check for compiling the ks8695eth
> > driver code to after including the headers. Otherwise it can never
> > be compiled in.
> 
> Applied. But please provide a proper CHANGELOG entry next time!
> 
> Best regards,
> 
> Wolfgang Denk
> 
> -- 
> Software Engineering:  Embedded and Realtime Systems,  Embedded Linux
> Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
> In an infinite universe all things are possible, including the possi-
> bility that the universe does not exist.
>                         - Terry Pratchett, _The Dark Side of the Sun_
> 
> 
> -------------------------------------------------------
> This SF.Net email is sponsored by xPML, a groundbreaking scripting language
> that extends applications into web and mobile media. Attend the live webcast
> and join the prime developer group breaking into this new coding territory!
> http://sel.as-us.falkag.net/sel?cmdlnk&kid\x110944&bid$1720&dat\x121642
> _______________________________________________
> U-Boot-Users mailing list
> U-Boot-Users at lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/u-boot-users



-- 
  lark

[U-Boot-Users] [PATCH] fix conditional for including ks8695eth driver

[Wolfgang Denk]

In message <20060313005521.8B6C.LARK@linux.net.cn> you wrote:
> 
> This commit breaks compile of boards without <asm/arch/platform.h>.

Thanks for pointing out. Fixed.

Best regards,

Wolfgang Denk

-- 
Software Engineering:  Embedded and Realtime Systems,  Embedded Linux
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
You don't have to stay up nights to succeed; you have to  stay  awake
days.