From mboxrd@z Thu Jan 1 00:00:00 1970 From: Wang Jian Date: Mon, 13 Mar 2006 01:04:35 +0800 Subject: [U-Boot-Users] [PATCH] fix conditional for including ks8695eth driver In-Reply-To: <20060312004036.2C6F0353A05@atlas.denx.de> References: <42A06968.3050706@moreton.com.au> <20060312004036.2C6F0353A05@atlas.denx.de> Message-ID: <20060313005521.8B6C.LARK@linux.net.cn> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi Wolfgang Denk, This commit breaks compile of boards without . Example: $ make Sandpoint8240_config; make Relevant files $ grep -R asm/arch/platform.h * board/cm41xx/cm41xx.c:#include board/cm4008/cm4008.c:#include cpu/arm920t/ks8695/interrupts.c:#include cpu/arm920t/ks8695/lowlevel_init.S:#include cpu/arm920t/ks8695/serial.c:#include drivers/ks8695eth.c:#include grep: include/asm/arch: No such file or directory grep: include/asm-ppc/arch: No such file or directory $ find . -name platform.h ./include/asm-microblaze/platform.h ./include/asm-arm/arch-ks8695/platform.h On Sun, 12 Mar 2006 01:40:36 +0100, Wolfgang Denk wrote: > In message <42A06968.3050706@moreton.com.au> you wrote: > > > > Move the c-preprocessor conditional check for compiling the ks8695eth > > driver code to after including the headers. Otherwise it can never > > be compiled in. > > Applied. But please provide a proper CHANGELOG entry next time! > > Best regards, > > Wolfgang Denk > > -- > Software Engineering: Embedded and Realtime Systems, Embedded Linux > Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de > In an infinite universe all things are possible, including the possi- > bility that the universe does not exist. > - Terry Pratchett, _The Dark Side of the Sun_ > > > ------------------------------------------------------- > This SF.Net email is sponsored by xPML, a groundbreaking scripting language > that extends applications into web and mobile media. Attend the live webcast > and join the prime developer group breaking into this new coding territory! > http://sel.as-us.falkag.net/sel?cmdlnk&kid0944&bid$1720&dat1642 > _______________________________________________ > U-Boot-Users mailing list > U-Boot-Users at lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/u-boot-users -- lark