From: Wang Jian <lark@linux.net.cn>
To: u-boot@lists.denx.de
Subject: Fw: [U-Boot-Users] [PATCH] Fix for configuration has both dataflash and parallel flash
Date: Sat, 15 Apr 2006 04:31:31 +0800 [thread overview]
Message-ID: <20060415042945.9029.LARK@linux.net.cn> (raw)
Hi Denk,
You really need to look at this patch.
Forwarded by Wang Jian <lark@linux.net.cn>
----------------------- Original Message -----------------------
From: Wang Jian <lark@linux.net.cn>
To: u-boot-users at lists.sourceforge.net
Date: Mon, 03 Apr 2006 15:22:31 +0800
Subject: [U-Boot-Users] [PATCH] Fix for configuration has both dataflash and parallel flash
----
Hi,
When the board has both dataflash and parallel flash, using 'cp' command
will write to parallel flash and then fail.
The patch below fixes the problem. BTW, I think "addr" is typo of "dest"
in the dataflash test, so the patch may be as simple as s/addr/dest/ in
dataflash test. I am in a hurry, so let suitable person to decide.
diff --git a/common/cmd_mem.c b/common/cmd_mem.c
index 0f4f9b7..a01c2a5 100644
--- a/common/cmd_mem.c
+++ b/common/cmd_mem.c
@@ -423,6 +423,7 @@ int do_mem_cp ( cmd_tbl_t *cmdtp, int fl
/* check if we are copying to Flash */
if ( (addr2info(dest) != NULL)
#ifdef CONFIG_HAS_DATAFLASH
+ && (!addr_dataflash(dest))
&& (!addr_dataflash(addr))
#endif
) {
--
lark
-------------------------------------------------------
This SF.Net email is sponsored by xPML, a groundbreaking scripting language
that extends applications into web and mobile media. Attend the live webcast
and join the prime developer group breaking into this new coding territory!
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=110944&bid=241720&dat=121642
_______________________________________________
U-Boot-Users mailing list
U-Boot-Users at lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/u-boot-users
--------------------- Original Message Ends --------------------
reply other threads:[~2006-04-14 20:31 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060415042945.9029.LARK@linux.net.cn \
--to=lark@linux.net.cn \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox