public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
* [U-Boot-Users] [PATCH] Generic LOGO support
@ 2006-07-12  8:18 Rodolfo Giometti
  2006-07-12  9:40 ` Rodolfo Giometti
  0 siblings, 1 reply; 7+ messages in thread
From: Rodolfo Giometti @ 2006-07-12  8:18 UTC (permalink / raw)
  To: u-boot

Hello,

here a patch to allow several boards to define their own LOGO file.

At configuration time we can specify the LOGO file as follow:

   wwpc1000_config         :       unconfig
           @ >include/config.h
           @echo "#define CONFIG_WWPC1000          100" >>include/config.h
           @./mkconfig -a wwpc1000 mips mips wwpc1000
           @echo "CROSS_COMPILE = mipsel-linux-" >>include/config.mk
           @echo "LOGO = wwpc1000.bmp" >>include/config.mk

Ciao,

Rodolfo

-- 

GNU/Linux Solutions                  e-mail:    giometti at enneenne.com
Linux Device Driver                             giometti at gnudd.com
Embedded Systems                     		giometti at linux.it
UNIX programming                     phone:     +39 349 2432127
-------------- next part --------------
diff --git a/Makefile b/Makefile
index f7a5f06..3ae8e3f 100644
--- a/Makefile
+++ b/Makefile
@@ -52,7 +52,7 @@ export	TOPDIR
 ifeq (include/config.mk,$(wildcard include/config.mk))
 # load ARCH, BOARD, and CPU configuration
 include include/config.mk
-export	ARCH CPU BOARD VENDOR SOC
+export	ARCH CPU BOARD VENDOR SOC LOGO
 ifndef CROSS_COMPILE
 ifeq ($(HOSTARCH),ppc)
 CROSS_COMPILE =
diff --git a/tools/Makefile b/tools/Makefile
index d3dcc7d..5b36ba2 100644
--- a/tools/Makefile
+++ b/tools/Makefile
@@ -38,8 +38,10 @@ #endif
 
 LOGO_H	= $(TOPDIR)/include/bmp_logo.h
 
-ifeq ($(LOGO_BMP),)
-LOGO_BMP= logos/denx.bmp
+ifeq ($(LOGO),)
+LOGO_BMP= denx.bmp
+else
+LOGO_BMP= $(LOGO)
 endif
 
 #-------------------------------------------------------------------------
@@ -195,8 +197,8 @@ crc32.c:
 		@rm -f crc32.c
 		ln -s ../lib_generic/crc32.c crc32.c
 
-$(LOGO_H):	bmp_logo $(LOGO_BMP)
-		./bmp_logo $(LOGO_BMP) >$@
+$(LOGO_H):	bmp_logo logos/$(LOGO_BMP)
+		./bmp_logo logos/$(LOGO_BMP) >$@ 2>/tmp/gu
 
 #########################################################################
 

^ permalink raw reply related	[flat|nested] 7+ messages in thread

* [U-Boot-Users] [PATCH] Generic LOGO support
  2006-07-12  8:18 [U-Boot-Users] [PATCH] Generic LOGO support Rodolfo Giometti
@ 2006-07-12  9:40 ` Rodolfo Giometti
  2006-07-12 17:52   ` Wolfgang Denk
  0 siblings, 1 reply; 7+ messages in thread
From: Rodolfo Giometti @ 2006-07-12  9:40 UTC (permalink / raw)
  To: u-boot

On Wed, Jul 12, 2006 at 10:17:59AM +0200, Rodolfo Giometti wrote:
> Hello,
> 
> here a patch to allow several boards to define their own LOGO file.

Sorry... the patch is wrong... here the correction.

diff --git a/tools/Makefile b/tools/Makefile
index 5b36ba2..5ce7445 100644
--- a/tools/Makefile
+++ b/tools/Makefile
@@ -198,7 +198,7 @@ crc32.c:
                ln -s ../lib_generic/crc32.c crc32.c
 
 $(LOGO_H):     bmp_logo logos/$(LOGO_BMP)
-               ./bmp_logo logos/$(LOGO_BMP) >$@ 2>/tmp/gu
+               ./bmp_logo logos/$(LOGO_BMP) >$@

Ciao,

Rodolfo

-- 

GNU/Linux Solutions                  e-mail:    giometti at enneenne.com
Linux Device Driver                             giometti at gnudd.com
Embedded Systems                     		giometti at linux.it
UNIX programming                     phone:     +39 349 2432127

^ permalink raw reply related	[flat|nested] 7+ messages in thread

* [U-Boot-Users] [PATCH] Generic LOGO support
  2006-07-12  9:40 ` Rodolfo Giometti
@ 2006-07-12 17:52   ` Wolfgang Denk
  2006-07-13  7:06     ` Rodolfo Giometti
  0 siblings, 1 reply; 7+ messages in thread
From: Wolfgang Denk @ 2006-07-12 17:52 UTC (permalink / raw)
  To: u-boot

In message <20060712094044.GA8581@gundam.enneenne.com> you wrote:
> 
> Sorry... the patch is wrong... here the correction.

May I ask you to debug and test your patches BEFORE posting, please?
Thanks.

And then don't send bits and pieces of corrections, please  repost  a
sane patch instead.

Best regards,

Wolfgang Denk

-- 
Software Engineering:  Embedded and Realtime Systems,  Embedded Linux
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
        Ordnung ist die Lust der Vernunft,
        aber Unordnung die Wonne der Phantasie         - Paul Claudel

^ permalink raw reply	[flat|nested] 7+ messages in thread

* [U-Boot-Users] [PATCH] Generic LOGO support
  2006-07-12 17:52   ` Wolfgang Denk
@ 2006-07-13  7:06     ` Rodolfo Giometti
  2006-07-13  7:16       ` Wolfgang Denk
  0 siblings, 1 reply; 7+ messages in thread
From: Rodolfo Giometti @ 2006-07-13  7:06 UTC (permalink / raw)
  To: u-boot

On Wed, Jul 12, 2006 at 07:52:37PM +0200, Wolfgang Denk wrote:
> 
> May I ask you to debug and test your patches BEFORE posting, please?
> Thanks.

Of course I did it, but... :)

> And then don't send bits and pieces of corrections, please  repost  a
> sane patch instead.

Ok, attached.

Ciao,

Rodolfo

-- 

GNU/Linux Solutions                  e-mail:    giometti at enneenne.com
Linux Device Driver                             giometti at gnudd.com
Embedded Systems                     		giometti at linux.it
UNIX programming                     phone:     +39 349 2432127
-------------- next part --------------
diff --git a/Makefile b/Makefile
index f7a5f06..3ae8e3f 100644
--- a/Makefile
+++ b/Makefile
@@ -52,7 +52,7 @@ export	TOPDIR
 ifeq (include/config.mk,$(wildcard include/config.mk))
 # load ARCH, BOARD, and CPU configuration
 include include/config.mk
-export	ARCH CPU BOARD VENDOR SOC
+export	ARCH CPU BOARD VENDOR SOC LOGO
 ifndef CROSS_COMPILE
 ifeq ($(HOSTARCH),ppc)
 CROSS_COMPILE =
diff --git a/tools/Makefile b/tools/Makefile
index d3dcc7d..5b36ba2 100644
--- a/tools/Makefile
+++ b/tools/Makefile
@@ -38,8 +38,10 @@ #endif
 
 LOGO_H	= $(TOPDIR)/include/bmp_logo.h
 
-ifeq ($(LOGO_BMP),)
-LOGO_BMP= logos/denx.bmp
+ifeq ($(LOGO),)
+LOGO_BMP= denx.bmp
+else
+LOGO_BMP= $(LOGO)
 endif
 
 #-------------------------------------------------------------------------
@@ -195,8 +197,8 @@ crc32.c:
 		@rm -f crc32.c
 		ln -s ../lib_generic/crc32.c crc32.c
 
-$(LOGO_H):	bmp_logo $(LOGO_BMP)
-		./bmp_logo $(LOGO_BMP) >$@
+$(LOGO_H):	bmp_logo logos/$(LOGO_BMP)
+		./bmp_logo logos/$(LOGO_BMP) >$@
 
 #########################################################################
 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
Url : http://lists.denx.de/pipermail/u-boot/attachments/20060713/65e55afd/attachment.pgp 

^ permalink raw reply related	[flat|nested] 7+ messages in thread

* [U-Boot-Users] [PATCH] Generic LOGO support
  2006-07-13  7:06     ` Rodolfo Giometti
@ 2006-07-13  7:16       ` Wolfgang Denk
  2006-07-13  7:32         ` Rodolfo Giometti
  2006-07-13  7:57         ` [U-Boot-Users] Does the UBoot-1.1.4 support the RMII on PPC440GP? Denny
  0 siblings, 2 replies; 7+ messages in thread
From: Wolfgang Denk @ 2006-07-13  7:16 UTC (permalink / raw)
  To: u-boot

In message <20060713070606.GC13250@hulk.enneenne.com> you wrote:
> 
> > And then don't send bits and pieces of corrections, please  repost  a
> > sane patch instead.
> 
> Ok, attached.

Where is the CHANGELOG message, and your Signed-off-by line?

Also, I cannot find any cleanup code for make clen?


Best regards,

Wolfgang Denk

-- 
Software Engineering:  Embedded and Realtime Systems,  Embedded Linux
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Schshschshchsch.
	-- The Gorn, "Arena", stardate 3046.2

^ permalink raw reply	[flat|nested] 7+ messages in thread

* [U-Boot-Users] [PATCH] Generic LOGO support
  2006-07-13  7:16       ` Wolfgang Denk
@ 2006-07-13  7:32         ` Rodolfo Giometti
  2006-07-13  7:57         ` [U-Boot-Users] Does the UBoot-1.1.4 support the RMII on PPC440GP? Denny
  1 sibling, 0 replies; 7+ messages in thread
From: Rodolfo Giometti @ 2006-07-13  7:32 UTC (permalink / raw)
  To: u-boot

On Thu, Jul 13, 2006 at 09:16:56AM +0200, Wolfgang Denk wrote:
> 
> Where is the CHANGELOG message, and your Signed-off-by line?

CHANGELOG:

Support for per board logo definition.

NOTE:

At configuration time we can specify the LOGO file as follow:

   wwpc1000_config         :       unconfig
           @ >include/config.h
           @echo "#define CONFIG_WWPC1000          100" >>include/config.h
           @./mkconfig -a wwpc1000 mips mips wwpc1000
           @echo "CROSS_COMPILE = mipsel-linux-" >>include/config.mk
           @echo "LOGO = wwpc1000.bmp" >>include/config.mk

Signed-off-by: Rodolfo Giometti <giometti@linux.it>

> Also, I cannot find any cleanup code for make clen?

What do you mean? My patch doesn't change file "include/bmp_logo.h"
generation... maybe there is a previous bug during "make clean"? I'll
check it.

Ciao,

Rodolfo

-- 

GNU/Linux Solutions                  e-mail:    giometti at enneenne.com
Linux Device Driver                             giometti at gnudd.com
Embedded Systems                     		giometti at linux.it
UNIX programming                     phone:     +39 349 2432127
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
Url : http://lists.denx.de/pipermail/u-boot/attachments/20060713/b5bbf93b/attachment.pgp 

^ permalink raw reply	[flat|nested] 7+ messages in thread

* [U-Boot-Users] Does the UBoot-1.1.4 support the RMII on PPC440GP?
  2006-07-13  7:16       ` Wolfgang Denk
  2006-07-13  7:32         ` Rodolfo Giometti
@ 2006-07-13  7:57         ` Denny
  1 sibling, 0 replies; 7+ messages in thread
From: Denny @ 2006-07-13  7:57 UTC (permalink / raw)
  To: u-boot

 
I still failed to bring up my ethernet on my custom PPC440GP board,
1. auto-negotiations timeout
2. wrong speed(10M), and wrong mode (half duplex)
Can anyone tell me how the drivers for PPC440GP RMII interface goes, thanks a lot!
 
Below is my logs:
u-boot => tftp 0x100000 tmp.img
Trying ppc_4xx_eth0
the ZMII_FER = 0xe0000780
the ZMII_SSR = 0xe0000784
Waiting for PHY auto negotiation to complete..... TIMEOUT !
 done
ENET Speed is 10 Mbps - HALF duplex connection
Using ppc_4xx_eth0 device
TFTP from server 192.168.65.235; our IP address is 192.168.65.239
Filename 'tmp.img'.
Load address: 0x100000
Loading: T T T T T T T 
 
Thanks in advance!
- Denny
 
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.denx.de/pipermail/u-boot/attachments/20060713/bd51fc77/attachment.htm 

^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2006-07-13  7:57 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-07-12  8:18 [U-Boot-Users] [PATCH] Generic LOGO support Rodolfo Giometti
2006-07-12  9:40 ` Rodolfo Giometti
2006-07-12 17:52   ` Wolfgang Denk
2006-07-13  7:06     ` Rodolfo Giometti
2006-07-13  7:16       ` Wolfgang Denk
2006-07-13  7:32         ` Rodolfo Giometti
2006-07-13  7:57         ` [U-Boot-Users] Does the UBoot-1.1.4 support the RMII on PPC440GP? Denny

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox