public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Stefan Roese <sr@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot-Users] skipping bad blocks when erasing nand
Date: Fri, 14 Jul 2006 10:47:07 +0200	[thread overview]
Message-ID: <200607141047.08126.sr@denx.de> (raw)
In-Reply-To: <20060714082857.CE206352681@atlas.denx.de>

Hello Wolfgang,

On Friday 14 July 2006 10:28, Wolfgang Denk wrote:
> in message <200607140914.07427.sr@denx.de> you wrote:
> > I am "voting" for David's implementation, since bad blocks are "normal"
> > on NAND chips. And if I remember correctly, the "old" U-Boot NAND driver
> > also just skipped the bad block upon erasing without reproting them.
>
> I'm sorry, but I disagree. This code is not coming out of  thin  air.
> It is a more or less vrbatim copy of the corresponding Linux MTD NAND
> code, see "drivers/mtd/nand/nand_base.c" in your Linux kernel tree.
>
> In U-Boot, we have the additional #define NAND_ALLOW_ERASE_ALL  which
> can be enabled if you don't like this behaviour.
>
> If you believe that the U-Boot behavious is wrong, then the Linux MTD
> driver would be wrong, too. In this case discussion  should  continue
> on the MTD mailing list.

I find it hard to believe that a linux NAND erase operation will stop upon 
reaching a bad block. But you are right: the code in question is the same in 
the current linux mtd driver. From my experience, I never had problems 
erasing NAND flash devices (from U-Boot & linux) which had bad blocks.

> As long as I don't see any changes to the current MTD Linux code  you
> will  need  really good arguments to talk me into changing the U-Boot
> code.

I see. You have a good point here. This needs some testing on a device with 
bad blocks. "Unfortunately" the device on my desk has no bad blocks at all:

=> nand bad

Device 0 bad blocks:

Perhaps somebody else can jump in here and test the current linux mtd driver 
behavior on a device with bad blocks. Thanks.

Best regards,
Stefan

  reply	other threads:[~2006-07-14  8:47 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-07-13 22:21 [U-Boot-Users] skipping bad blocks when erasing nand David Byron
2006-07-13 22:45 ` Wolfgang Denk
2006-07-13 23:13   ` Dave Hylands
2006-07-14  7:10     ` Joachim Jaeger
2006-07-14  7:14   ` Stefan Roese
2006-07-14  8:28     ` Wolfgang Denk
2006-07-14  8:47       ` Stefan Roese [this message]
2006-07-14  9:29         ` Wolfgang Denk
2006-07-14  9:58         ` Joachim Jaeger
2006-07-14 11:19           ` Wolfgang Denk
2006-08-22  9:44             ` Ladislav Michl
  -- strict thread matches above, loose matches on Subject: below --
2006-07-17 21:42 David Byron
2006-07-20 23:22 ` Tolunay Orkun
2006-07-21  4:27   ` Stefan Roese
2006-07-13 21:35 David Byron
2006-07-13 21:48 ` Wolfgang Denk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200607141047.08126.sr@denx.de \
    --to=sr@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox