public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: sagarwal <sagarwal@teaktechnologies.com>
To: u-boot@lists.denx.de
Subject: [U-Boot-Users] tsec ethernet link bug?
Date: Tue, 8 Aug 2006 15:54:20 -0700	[thread overview]
Message-ID: <20060808225419.GA15794@teaktechnologies.com> (raw)

Hi 

I'm using a 8548CDS board and I have a link plugged
into eth1 (but not eth0). When I run u-boot, it thinks
that eth0 is plugged in and keeps trying tftp on that 
port. 

I think there is a little bug in the code - here is a
diff. Basically priv->link inadvertently gets set to 
1 when the timeout case breaks out of the 
while loop inside the routine mii_parse_sr(). 

Could somebody please confirm if they have seen 
this? 

thanks. 

===============================================================

diff --git a/drivers/tsec.c b/drivers/tsec.c
index f860dae..06c25bc 100644
--- a/drivers/tsec.c
+++ b/drivers/tsec.c
@@ -363,7 +363,7 @@ uint mii_parse_sr(uint mii_reg, struct t
                        if (i > PHY_AUTONEGOTIATE_TIMEOUT) {
                                puts (" TIMEOUT !\n");
                                priv->link = 0;
-                               break;
+                               return 0;
                        }

                        if ((i++ % 1000) == 0) {

================================================================

                 reply	other threads:[~2006-08-08 22:54 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060808225419.GA15794@teaktechnologies.com \
    --to=sagarwal@teaktechnologies.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox