From mboxrd@z Thu Jan 1 00:00:00 1970 From: sagarwal Date: Tue, 8 Aug 2006 15:54:20 -0700 Subject: [U-Boot-Users] tsec ethernet link bug? Message-ID: <20060808225419.GA15794@teaktechnologies.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi I'm using a 8548CDS board and I have a link plugged into eth1 (but not eth0). When I run u-boot, it thinks that eth0 is plugged in and keeps trying tftp on that port. I think there is a little bug in the code - here is a diff. Basically priv->link inadvertently gets set to 1 when the timeout case breaks out of the while loop inside the routine mii_parse_sr(). Could somebody please confirm if they have seen this? thanks. =============================================================== diff --git a/drivers/tsec.c b/drivers/tsec.c index f860dae..06c25bc 100644 --- a/drivers/tsec.c +++ b/drivers/tsec.c @@ -363,7 +363,7 @@ uint mii_parse_sr(uint mii_reg, struct t if (i > PHY_AUTONEGOTIATE_TIMEOUT) { puts (" TIMEOUT !\n"); priv->link = 0; - break; + return 0; } if ((i++ % 1000) == 0) { ================================================================