public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Wolfgang Denk <wd@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot-Users] [PATCH] Define upmconfig() for 834x systems
Date: Sat, 09 Sep 2006 00:32:26 +0200	[thread overview]
Message-ID: <20060908223226.79375353AD0@atlas.denx.de> (raw)
In-Reply-To: Your message of "Fri, 08 Sep 2006 16:47:03 CDT." <11577520232114-git-send-email-timur@freescale.com>

In message <11577520232114-git-send-email-timur@freescale.com> you wrote:
> 
> * Define upmconfig() for 834x systems, and hang if called on non-834x systems.
>   This function programs one of the UPMs with the code passed to it.  The
>   BR and OR for the chosen bank (any bank will do) and the MxMR must all be
>   programmed correctly before calling this function.

I don't see any users for this function. Please don't add dead code.

If you intend to use this with any future patches, then please submit
your patches in an order that makes some sense.

Also, please follow the Coding  Style  requirements  (trailing  white
space).

Best regards,

Wolfgang Denk

-- 
Software Engineering:  Embedded and Realtime Systems,  Embedded Linux
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Be careful what you wish for. You never know who will be listening.
                                      - Terry Pratchett, _Soul Music_

  reply	other threads:[~2006-09-08 22:32 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-09-08 21:47 [U-Boot-Users] [PATCH] Define upmconfig() for 834x systems timur at freescale.com
2006-09-08 22:32 ` Wolfgang Denk [this message]
2006-09-08 22:50   ` Timur Tabi
2006-09-08 23:05     ` Wolfgang Denk
2006-09-11 17:37       ` Ben Warren
2006-09-11 17:53         ` Timur Tabi
2006-09-11 18:52           ` Wolfgang Denk
2006-09-11 18:52             ` [U-Boot-Users] 86xx patches? (was [PATCH] Define upmconfig() for 834x systems) Jon Loeliger
2006-09-11 18:46         ` [U-Boot-Users] [PATCH] Define upmconfig() for 834x systems Wolfgang Denk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060908223226.79375353AD0@atlas.denx.de \
    --to=wd@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox