From: Stefan Roese <sr@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot-Users] [PATCH] Updates NAND Flash controller support in PPC 440 EP/GR/x
Date: Fri, 20 Oct 2006 14:23:56 +0200 [thread overview]
Message-ID: <200610201423.56937.sr@denx.de> (raw)
In-Reply-To: <1628E43D99629C46988BE46087A3FBB972A2A2@ep-01.EmbeddedPlanet.local>
Hi Jeff,
On Wednesday 18 October 2006 23:38, Jeff Mann wrote:
> It looks good, but I see one minor problem: in nand_init(...) in
> drivers/nand/nand.c, nand_curr_device is set to the first nand device
> that is found. In the nand flash controller driver board_nand_init(...),
> the chip select is set. So after two or more devices are found, the chip
> select is left set to the last device while nand_curr_device is set for
> the first. A call to board_nand_select_device(...) is needed at the end
> of nand_init(...) to set the chip selects correctly.
Yes, I overlooked this. Thanks. I'll update the code and commit in the next
few days.
Best regards,
Stefan
next prev parent reply other threads:[~2006-10-20 12:23 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-18 21:38 [U-Boot-Users] [PATCH] Updates NAND Flash controller support in PPC 440 EP/GR/x Jeff Mann
2006-10-20 12:23 ` Stefan Roese [this message]
2006-10-21 10:04 ` Stefan Roese
-- strict thread matches above, loose matches on Subject: below --
2006-10-10 13:06 Jeff Mann
2006-10-18 14:44 ` Stefan Roese
2006-10-09 21:36 Jeff Mann
2006-10-10 9:48 ` Stefan Roese
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200610201423.56937.sr@denx.de \
--to=sr@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox