From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stefan Roese Date: Fri, 20 Oct 2006 14:23:56 +0200 Subject: [U-Boot-Users] [PATCH] Updates NAND Flash controller support in PPC 440 EP/GR/x In-Reply-To: <1628E43D99629C46988BE46087A3FBB972A2A2@ep-01.EmbeddedPlanet.local> References: <1628E43D99629C46988BE46087A3FBB972A2A2@ep-01.EmbeddedPlanet.local> Message-ID: <200610201423.56937.sr@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi Jeff, On Wednesday 18 October 2006 23:38, Jeff Mann wrote: > It looks good, but I see one minor problem: in nand_init(...) in > drivers/nand/nand.c, nand_curr_device is set to the first nand device > that is found. In the nand flash controller driver board_nand_init(...), > the chip select is set. So after two or more devices are found, the chip > select is left set to the last device while nand_curr_device is set for > the first. A call to board_nand_select_device(...) is needed at the end > of nand_init(...) to set the chip selects correctly. Yes, I overlooked this. Thanks. I'll update the code and commit in the next few days. Best regards, Stefan