[U-Boot-Users] [PATCH] Updates NAND Flash controller support in PPC 440 EP/GR/x

[U-Boot-Users] [PATCH] Updates NAND Flash controller support in PPC 440 EP/GR/x

[Jeff Mann]

Stefan:
>Please give the attached version a try and let me know if it works for
you. If nobody objects this will go into the official tree soon.

It looks good, but I see one minor problem: in nand_init(...) in
drivers/nand/nand.c, nand_curr_device is set to the first nand device
that is found. In the nand flash controller driver board_nand_init(...),
the chip select is set. So after two or more devices are found, the chip
select is left set to the last device while nand_curr_device is set for
the first. A call to board_nand_select_device(...) is needed at the end
of nand_init(...) to set the chip selects correctly.

-Jeff

[U-Boot-Users] [PATCH] Updates NAND Flash controller support in PPC 440 EP/GR/x

[Stefan Roese]

Hi Jeff,

On Wednesday 18 October 2006 23:38, Jeff Mann wrote:
> It looks good, but I see one minor problem: in nand_init(...) in
> drivers/nand/nand.c, nand_curr_device is set to the first nand device
> that is found. In the nand flash controller driver board_nand_init(...),
> the chip select is set. So after two or more devices are found, the chip
> select is left set to the last device while nand_curr_device is set for
> the first. A call to board_nand_select_device(...) is needed at the end
> of nand_init(...) to set the chip selects correctly.

Yes, I overlooked this. Thanks. I'll update the code and commit in the next 
few days.

Best regards,
Stefan

[U-Boot-Users] [PATCH] Updates NAND Flash controller support in PPC 440 EP/GR/x

[Stefan Roese]

On Friday 20 October 2006 14:23, Stefan Roese wrote:
> Yes, I overlooked this. Thanks. I'll update the code and commit in the next
> few days.

Applied. Thanks.

Best regards,
Stefan

[U-Boot-Users] [PATCH] Updates NAND Flash controller support in PPC 440 EP/GR/x

[Jeff Mann]

Resend of the correct file. Sorry about that.

> *CHANGELOG
>  updates the NAND flash controller support for PPC 440 EP/GR/x 
> processors to allow for multiple nand devices on the controller.
>  Patch By Jeffrey Mann, Embedded Planet.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: ppc440NDFC.patch
Type: application/octet-stream
Size: 6310 bytes
Desc: ppc440NDFC.patch
Url : http://lists.denx.de/pipermail/u-boot/attachments/20061010/eb675e38/attachment.obj 

[U-Boot-Users] [PATCH] Updates NAND Flash controller support in PPC 440 EP/GR/x

[Stefan Roese]

Hi Jeff,

On Tuesday 10 October 2006 15:06, Jeff Mann wrote:
> Resend of the correct file. Sorry about that.
>
> > *CHANGELOG
> >  updates the NAND flash controller support for PPC 440 EP/GR/x
> > processors to allow for multiple nand devices on the controller.
> >  Patch By Jeffrey Mann, Embedded Planet.

I was not totally satisfied with the way you implemented the device selection 
and since I have a Sequoia on my desk right now, I implemented a slightly 
different version.

Please give the attached version a try and let me know if it works for you. If 
nobody objects this will go into the official tree soon.

Best regards,
Stefan
-------------- next part --------------
A non-text attachment was scrubbed...
Name: ndfc-jeff-mann.patch
Type: text/x-diff
Size: 6589 bytes
Desc: not available
Url : http://lists.denx.de/pipermail/u-boot/attachments/20061018/f69148f1/attachment.patch 

[U-Boot-Users] [PATCH] Updates NAND Flash controller support in PPC 440 EP/GR/x

[Jeff Mann]

This patch updates the NAND flash controller support for PPC 440 EP/GR/x
processors to support up to the maximum of four devices on the
controller. In addition, the NAND initialization streamlines the
additional of future controller support for future boards by calling the
chip select function through a function (nand_select_device(void)) in
nand.c such that calls to board or processor specific functions can be
added in one place instead of in several of the nand files. 

As discusses with Stefan, the configuration format is 
	#define CFG_NAND_BASE_LIST	{ CFG_NAND_BASE + 1,
CFG_NAND_BASE + 2 ....}

The Sequoia board will need to be updated, which I will do when we get
the next build of them back here in a few days. 
------------------

*CHANGELOG
 updates the NAND flash controller support for PPC 440 EP/GR/x
processors to allow for multiple nand devices on the controller.
 Patch By Jeffrey Mann, Embedded Planet.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: M41T62.patch
Type: application/octet-stream
Size: 7305 bytes
Desc: M41T62.patch
Url : http://lists.denx.de/pipermail/u-boot/attachments/20061009/0d033615/attachment.obj 

[U-Boot-Users] [PATCH] Updates NAND Flash controller support in PPC 440 EP/GR/x

[Stefan Roese]

Hi Jeff,

On Monday 09 October 2006 23:36, Jeff Mann wrote:
> This patch updates the NAND flash controller support for PPC 440 EP/GR/x
> processors to support up to the maximum of four devices on the
> controller. In addition, the NAND initialization streamlines the
> additional of future controller support for future boards by calling the
> chip select function through a function (nand_select_device(void)) in
> nand.c such that calls to board or processor specific functions can be
> added in one place instead of in several of the nand files.
>
> As discusses with Stefan, the configuration format is
> 	#define CFG_NAND_BASE_LIST	{ CFG_NAND_BASE + 1,
> CFG_NAND_BASE + 2 ....}
>
> The Sequoia board will need to be updated, which I will do when we get
> the next build of them back here in a few days.

Does this mean that your patch leaves the Sequoia support broken for now? This 
is not acceptable. If this is the case, then please update the current 
Sequoia support to work with your updated NAND support.

> *CHANGELOG
>  updates the NAND flash controller support for PPC 440 EP/GR/x
> processors to allow for multiple nand devices on the controller.
>  Patch By Jeffrey Mann, Embedded Planet.

Hmmm. You have attached the wrong file. Nothing is dealing with the 440 NDFC 
in this file. Please resend. Thanks.

Best regards,
Stefan