public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Stefan Roese <sr@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot-Users] [PATCH] simplify silent console
Date: Mon, 30 Oct 2006 09:25:14 +0100 (MET)	[thread overview]
Message-ID: <200610300926.07172.sr@denx.de> (raw)
In-Reply-To: <20060725153003.GA21533@orphique>

Hi Ladis,

On Tuesday 25 July 2006 17:30, Ladislav Michl wrote:
> silent console output is currently implemented by assigning nulldev
> as output device. This is a bit overcomplicated, since there is
> also GD_FLG_SILENT flag.
>
> Patch bellow tries to simplify silencing console by honouring
> GD_FLG_SILENT in console output functions, so there is no need to
> mess with output device. Comments?

Good idea. One thing though: After applying your patch the system _does_ print 
the bootcount messages "Hit any key to stop autoboot: ..." even if 
the "silent" variable is set. This was not done with the previous 
implementation and is not intended. Could you please rework your patch, that 
no message is printed here?

And please update the README.silent documentation too to match the updated 
implementation.

Thanks.

Best regards,
Stefan

  reply	other threads:[~2006-10-30  8:25 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-07-25 15:30 [U-Boot-Users] [PATCH] simplify silent console Ladislav Michl
2006-10-30  8:25 ` Stefan Roese [this message]
2007-04-24 12:02   ` Ladislav Michl
2007-04-24 12:10     ` Wolfgang Denk
2007-04-24 12:25       ` Ladislav Michl

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200610300926.07172.sr@denx.de \
    --to=sr@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox