From mboxrd@z Thu Jan  1 00:00:00 1970
From: Stefan Roese <sr@denx.de>
Date: Tue, 7 Nov 2006 19:16:39 +0100 (MET)
Subject: [U-Boot-Users] [PATCH] Where does U-Boot's CFI driver check for
	top/bottom boot?
In-Reply-To: <4550CA15.80605@orkun.us>
References: <11628568123033-git-send-email-timur@freescale.com>
	<4550C155.2030202@freescale.com> <4550CA15.80605@orkun.us>
Message-ID: <200611071918.22319.sr@denx.de>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Hi Tolunay,

On Tuesday 07 November 2006 19:01, Tolunay Orkun wrote:
> Questions for the maintainers:
>
> 1) I have some new variables for man_id, dev_id, cfi_version introduced by
> this patch (actually man_id is currently not used so could be removed). I
> can kept these local to the function for now or I can add them to the info
> structure along with ext_addr (to easily locate the Vendor Extended Query
> Structure in flash). What do you think?
>
> In the minimum displaying man_id, dev_id, cfi_version when executing
> "flinfo" command could be useful for diagnostic purposes. We might need to
> use them to tweak the behavior of some other functionality in the future as
> well.

Yes, I definitely think it's useful to display this ID information (or even 
better a real manufacturer/device string) in the "flinfo" command. So my vote 
is to extend the struct.

> 2) There are some outdated comments at the beginning of the cfi_flash.c.
> The modification history is not up to date and todo list stuff is mostly
> addressed over time. Since the actual history is already is the git, I
> propose to get rid of modification history and todo list from the comments.

ACK.

Thanks for helping out here.

Best regards,
Stefan