[U-Boot-Users] [PATCH] CFI driver AMD Command Set Top boot geometry reversal, etc. [Updated]

[Stefan Roese <sr@denx.de>]

Hi Tolunay,

On Sunday 12 November 2006 05:42, Tolunay Orkun wrote:
> > In flash_read_jedec_ids(), make this change:
> >
> > -               flash_write_cmd(info, 0, 0, FLASH_CMD_READ_ID);
> > +               flash_write_cmd(info, 0, AMD_ADDR_START,
> > FLASH_CMD_READ_ID);
>
> I think this change is what was missing which I overlooked. Intel does
> not need a specific address to write the command nor unlock sequence.

And that's the reason I don't like those Intel devices. I got some devices 
accidentally screwed in a project once.

> > Now when I run flinfo, I get this:
> >
> > Bank # 1: CFI conformant FLASH (16 x 16)  Size: 8 MB in 135 Sectors
> >   AMD Standard command set, Manufacturer ID: 0xC2, Device ID: 0xC9
> >   Erase timeout: 16384 ms, write timeout: 1 ms

And I get:

=> fli

Bank # 1: CFI conformant FLASH (16 x 16)  Size: 2 MB in 35 Sectors
  AMD Standard command set, Manufacturer ID: 0x20, Device ID: 0xC4
  Erase timeout: 8192 ms, write timeout: 1 ms

  Sector Start Addresses:
  FFE00000        FFE10000        FFE20000 E      FFE30000 E      FFE40000 E
  FFE50000 E      FFE60000 E      FFE70000 E      FFE80000 E      FFE90000 E
  FFEA0000 E      FFEB0000 E      FFEC0000 E      FFED0000 E      FFEE0000 E
  FFEF0000 E      FFF00000 E      FFF10000 E      FFF20000 E      FFF30000 E
  FFF40000 E      FFF50000 E      FFF60000 E      FFF70000 E      FFF80000 E
  FFF90000 E      FFFA0000   RO   FFFB0000   RO   FFFC0000   RO   FFFD0000   
RO
  FFFE0000   RO   FFFF0000   RO   FFFF8000 E      FFFFA000 E      FFFFC000

So FLASH ID's are now read back correctly.

> There was no flash_read_jedec_ids() before I sent the last patch. I
> wrote it from scratch and the bug there belongs to me :)

;-)

> Since, I did 
> not have AMD style flash myself was not able to test that path and that
> is why I was asking you to collect debug data . It is hard to prepare
> patches for an issue that you do not have in house :)

As usual the rule applies: "never tested, never running". Thanks a lot for 
even trying to fix a patch for this without having the hardware. :)

> I will update the patch tonight and resend it yet again.

Not necessary. I'll forward this patch with the fix to Wolfgang. Thanks again.

And when it's included we can continue to extend the code with additional 
features, like fixing this ST FLASH geometry reversal (or others) by 
identifying it's device ID.

Best regards,
Stefan