[U-Boot-Users] Why is ENV_IS_EMBEDDED globally define when NAND bootloader is built ?

[U-Boot-Users] Why is ENV_IS_EMBEDDED globally define when NAND bootloader is built ?

[Spence Nick-rxtd10]

Hello Stefan,
 
I am trying to set up a NAND_SPL bootloader for a different PowerPC
processor.
 
I want to store the environment variables in the NAND Flash at a
location above the boot loader, so that I can reprogram the bootloader
without overwriting the variables when I copy the u-boot-nand.bin image
into the NAND flash.
 
However in the changes made on Sept 12, the include/environment.h file
was modified to define ENV_IS_EMBEDDED whenever CONFIG_NAND_U_BOOT is
defined.
 
Is there any reason that this configuration setting cannot be moved into
the board specific include file instead ?
 
diff --git a/include/configs/sequoia.h b/include/configs/sequoia.h
index 3a76315..33ff4cf 100644
--- a/include/configs/sequoia.h
+++ b/include/configs/sequoia.h
@@ -102,6 +102,7 @@ #if !defined(CONFIG_NAND_U_BOOT) && !def
 #define CFG_ENV_IS_IN_FLASH     1 /* use FLASH for environment vars */
 #else
 #define CFG_ENV_IS_IN_NAND 1 /* use NAND for environment vars */
+#define ENV_IS_EMBEDDED  1 /* use embedded environment */
 #endif
 
 
/*----------------------------------------------------------------------
-
diff --git a/include/environment.h b/include/environment.h
index 26b0712..422f800 100644
--- a/include/environment.h
+++ b/include/environment.h
@@ -79,10 +79,6 @@ # endif
 # ifdef CFG_ENV_OFFSET_REDUND
 #  define CFG_REDUNDAND_ENVIRONMENT
 # endif
-# if defined(CONFIG_NAND_U_BOOT)
-/* Use embedded environment in NAND boot versions */
-#  define ENV_IS_EMBEDDED 1
-# endif
 #endif /* CFG_ENV_IS_IN_NAND */

Am I missing something ?

Thanks,

Nick Spence
Freescale Semiconductor,
1300 N. Alma School Road, Chandler, AZ 85224

[U-Boot-Users] Why is ENV_IS_EMBEDDED globally define when NAND bootloader is built ?

[Stefan Roese]

Hi Nick,

On Monday 20 November 2006 09:16, Spence Nick-rxtd10 wrote:
> I am trying to set up a NAND_SPL bootloader for a different PowerPC
> processor.

Good. Additional board/cpu support for this new U-Boot NAND booting feature is 
very welcome. :-)

> I want to store the environment variables in the NAND Flash at a
> location above the boot loader, so that I can reprogram the bootloader
> without overwriting the variables when I copy the u-boot-nand.bin image
> into the NAND flash.

Understood. Just a side note: You could use a command that runs "saveenv" upon 
updating the U-Boot image. This way you won't loose the environment.

> However in the changes made on Sept 12, the include/environment.h file
> was modified to define ENV_IS_EMBEDDED whenever CONFIG_NAND_U_BOOT is
> defined.
>
> Is there any reason that this configuration setting cannot be moved into
> the board specific include file instead ?

Not really. We can move this define into some board specific place. We should 
use the define "CFG_ENV_IS_EMBEDDED" in the board config file though and not 
the define "ENV_IS_EMBEDDED".

Best regards,
Stefan