From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stefan Roese Date: Mon, 20 Nov 2006 10:21:03 +0100 (MET) Subject: [U-Boot-Users] Why is ENV_IS_EMBEDDED globally define when NAND bootloader is built ? In-Reply-To: <9E50B2A5FE44294CBF877745D9A4125FC1FA6E@az33exm24.fsl.freescale.net> References: <9E50B2A5FE44294CBF877745D9A4125FC1FA6E@az33exm24.fsl.freescale.net> Message-ID: <200611201022.13649.sr@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi Nick, On Monday 20 November 2006 09:16, Spence Nick-rxtd10 wrote: > I am trying to set up a NAND_SPL bootloader for a different PowerPC > processor. Good. Additional board/cpu support for this new U-Boot NAND booting feature is very welcome. :-) > I want to store the environment variables in the NAND Flash at a > location above the boot loader, so that I can reprogram the bootloader > without overwriting the variables when I copy the u-boot-nand.bin image > into the NAND flash. Understood. Just a side note: You could use a command that runs "saveenv" upon updating the U-Boot image. This way you won't loose the environment. > However in the changes made on Sept 12, the include/environment.h file > was modified to define ENV_IS_EMBEDDED whenever CONFIG_NAND_U_BOOT is > defined. > > Is there any reason that this configuration setting cannot be moved into > the board specific include file instead ? Not really. We can move this define into some board specific place. We should use the define "CFG_ENV_IS_EMBEDDED" in the board config file though and not the define "ENV_IS_EMBEDDED". Best regards, Stefan