From: Stefan Roese <sr@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot-Users] MC68360 port
Date: Wed, 22 Nov 2006 13:31:53 +0100 (MET) [thread overview]
Message-ID: <200611221333.11432.sr@denx.de> (raw)
In-Reply-To: <8496f91a0611202248h1e43d4b4sc2961f67dba6c6fc@mail.gmail.com>
On Tuesday 21 November 2006 07:48, Matvejchikov Ilya wrote:
> I have ported U-Boot-1.1.6 to MC68360 based board. See the attached
> file for details. E-mail me if you have any questions :)
Thanks.
Some comments:
- Are you sure that you can't use the common CFI FLASH driver?
- Please don't use C++ style comments.
- Use tabs for indentation (for example in board/mc68360/mc68360.c).
- Please rework your board config file. There is no comment at all
so this is not readable.
Best regards,
Stefan
next prev parent reply other threads:[~2006-11-22 12:31 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-11-21 6:48 [U-Boot-Users] MC68360 port Matvejchikov Ilya
2006-11-22 12:31 ` Stefan Roese [this message]
2006-11-23 8:06 ` Matvejchikov Ilya
2006-11-23 10:35 ` Stefan Roese
2006-11-25 16:42 ` Matvejchikov Ilya
2006-11-25 19:13 ` Stefan Roese
2006-11-26 6:16 ` Tolunay Orkun
2006-11-26 6:19 ` Tolunay Orkun
2006-11-26 10:15 ` Stefan Roese
2006-11-26 22:30 ` Matvejchikov Ilya
-- strict thread matches above, loose matches on Subject: below --
2006-11-21 6:47 Matvejchikov Ilya
2003-03-06 21:36 [U-Boot-Users] MC68360 Port Keith Outwater
2003-03-06 20:14 [U-Boot-Users] [Patch]: A small patch for PPC4xx I2C driver Wolfgang Denk
2003-03-06 20:47 ` [U-Boot-Users] MC68360 Port Reinhard Meyer
2003-03-06 21:49 ` Wolfgang Denk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200611221333.11432.sr@denx.de \
--to=sr@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox