* [U-Boot-Users] [PATCH] 4xx_enet.c: Correct the setting of zmiifer register.
@ 2006-11-24 13:17 Neil Wilson
2006-11-28 9:46 ` Stefan Roese
0 siblings, 1 reply; 2+ messages in thread
From: Neil Wilson @ 2006-11-24 13:17 UTC (permalink / raw)
To: u-boot
Patch below corrects the setting of the zmiifer register, it was
overwritting the register rather than ORing the settings.
Neil
--
Neil Wilson
Principal Engineer, Embedded Software
Airspan Communications Ltd
Cambridge House, Oxford Road
Uxbridge, Middlesex, UB8 1UN, UK.
+44(0)1895-467265
neilwilson at airspan.com
--
diff --git a/cpu/ppc4xx/4xx_enet.c b/cpu/ppc4xx/4xx_enet.c
index 81d49ff..aefe126 100644
--- a/cpu/ppc4xx/4xx_enet.c
+++ b/cpu/ppc4xx/4xx_enet.c
@@ -264,10 +264,10 @@ int ppc_4xx_eth_setup_bridge(int devnum,
bis->bi_phymode[3] = BI_PHYMODE_ZMII;
break;
case 2:
- zmiifer = ZMII_FER_SMII << ZMII_FER_V(0);
- zmiifer = ZMII_FER_SMII << ZMII_FER_V(1);
- zmiifer = ZMII_FER_SMII << ZMII_FER_V(2);
- zmiifer = ZMII_FER_SMII << ZMII_FER_V(3);
+ zmiifer |= ZMII_FER_SMII << ZMII_FER_V(0);
+ zmiifer |= ZMII_FER_SMII << ZMII_FER_V(1);
+ zmiifer |= ZMII_FER_SMII << ZMII_FER_V(2);
+ zmiifer |= ZMII_FER_SMII << ZMII_FER_V(3);
bis->bi_phymode[0] = BI_PHYMODE_ZMII;
bis->bi_phymode[1] = BI_PHYMODE_ZMII;
bis->bi_phymode[2] = BI_PHYMODE_ZMII;
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [U-Boot-Users] [PATCH] 4xx_enet.c: Correct the setting of zmiifer register.
2006-11-24 13:17 [U-Boot-Users] [PATCH] 4xx_enet.c: Correct the setting of zmiifer register Neil Wilson
@ 2006-11-28 9:46 ` Stefan Roese
0 siblings, 0 replies; 2+ messages in thread
From: Stefan Roese @ 2006-11-28 9:46 UTC (permalink / raw)
To: u-boot
On Friday 24 November 2006 14:17, Neil Wilson wrote:
> Patch below corrects the setting of the zmiifer register, it was
> overwritting the register rather than ORing the settings.
Applied. Thanks.
Best regards,
Stefan
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2006-11-28 9:46 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-11-24 13:17 [U-Boot-Users] [PATCH] 4xx_enet.c: Correct the setting of zmiifer register Neil Wilson
2006-11-28 9:46 ` Stefan Roese
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox