From mboxrd@z Thu Jan 1 00:00:00 1970 From: Matthias Fuchs Date: Mon, 15 Jan 2007 07:08:47 +0100 Subject: [U-Boot-Users] reg ISP 1561 integration with u-boot1.1.6 In-Reply-To: <87ps9ksdun.fsf@denx.de> References: <4ac2955e0701040358u5699f021o163696f8cf70ba4a@mail.gmail.com> <200701111606.12878.matthias.fuchs@esd-electronics.com> <87ps9ksdun.fsf@denx.de> Message-ID: <200701150708.47499.matthias.fuchs@esd-electronics.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi Markus, On Friday 12 January 2007 12:07, Markus Klotzb?cher wrote: > Hi Matthias, > > Matthias Fuchs writes: > > > Sounds reasonable to me. We still need a more pretty way to handle the > > +/- CFG_PCIRAM_BASE. What about some cpu_to_bus/bus_to_cpu macros? > > Hmm, that sounds a bit confusing too if you're only accessing a on chip > controller. How about just renaming the define to something more generic > such as CFG_OHCI_RAM_OFFSET and adding a nice explanation in the README? > That way it wouldn't seem so strongly related to pci. When dealing with a pci OHCI controller the offset if pci related. But you are right, when not running on a PCI platform your name ist better. BTW, considering Wolfgang's desire for multi ohci controller support, the constant will change into a field in the ohci struct. Matthias