From mboxrd@z Thu Jan  1 00:00:00 1970
From: Stefan Roese <sr@denx.de>
Date: Sat, 10 Feb 2007 20:15:23 +0100
Subject: [U-Boot-Users] [PATCH] Add first Netstal board HCU4
In-Reply-To: <200702101001.51830.niklaus.giger@member.fsf.org>
References: <200702092137.23677.niklaus.giger@member.fsf.org>
	<200702100859.39957.sr@denx.de>
	<200702101001.51830.niklaus.giger@member.fsf.org>
Message-ID: <200702102015.23701.sr@denx.de>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

On Saturday 10 February 2007 10:01, Niklaus Giger wrote:
> > Yes, that has mostly historic reasons. So why do you have to use a board
> > specific flash driver and not the common cfi driver?
>
> Because I started with a board that had a board specific flash.c, which
> worked. And a first attempt to use the common CFI failed, as I mixed too
> many changes. But I will try next week to follow you suggestion.

What flash devices do you use on your board?

> > So the current patch doesn't include this ECC support? Do you use the 4xx
> > SPD driver (cpu/ppc/spd_sdram.c) or the no SPD driver (cpu/ppc/sdram.c)?
> > Or even a board specif one?
>
> Yes it does not.
>
> I did not want to mix in a single patch a new board and a new feature. And
> as it is the first time I work with git I not know how to easily work on
> two different patches at the same time. But I will try next week to come up
> with a patch for ECC.
>
> I think I use cpu/ppc/spd_sdram.c as I call in my init_dram procedure ?
>    dram_size = spd_sdram(0);

Yes, you are using the common 4xx SPD driver then.

> Alternatively I first brought up my board using the known good values for
> the sdram registers in my procedure fixed_hcu4_sdram, which I left for
> debugging purposes #if !defined(CONFIG_SPD_EEPROM).

I'll try to take a deeper look at your patch on Monday.

> Thanks for your tips.

You're welcome.

Best regards,
Stefan

=====================================================================
DENX Software Engineering GmbH, HRB 165235 Munich, CEO: Wolfgang Denk
Office:  Kirchenstr. 5,       D-82194 Groebenzell,            Germany
=====================================================================