From: Stefan Roese <sr@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot-Users] [PATCH] Add S3C2410 MMC/SD support
Date: Sat, 17 Feb 2007 08:20:22 +0100 [thread overview]
Message-ID: <200702170820.22650.sr@denx.de> (raw)
In-Reply-To: <528646bc0702161831p4f96dfc0qd6b99626a7e0f856@mail.gmail.com>
On Saturday 17 February 2007 03:31, Grant Likely wrote:
> Here are some comments after a quick review.
And some more...
<snip>
> > +static u_int32_t *
> > +/****************************************************/
> > +mmc_cmd(ushort cmd, ulong arg, ushort flags)
> > +/****************************************************/
>
> I'm not so fond of the style putting a comment line between the
> function name and the return type. I think they should be together.
> What does everyone else think?
ACK. Very confusing this way.
Best regards,
Stefan
next prev parent reply other threads:[~2007-02-17 7:20 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-02-16 23:02 [U-Boot-Users] [PATCH] Add S3C2410 MMC/SD support Harald Welte
2007-02-16 23:48 ` Haavard Skinnemoen
2007-02-17 11:18 ` Harald Welte
2007-02-17 15:00 ` Wolfgang Denk
2008-01-28 14:17 ` Peter Pearse
2007-02-17 2:31 ` Grant Likely
2007-02-17 7:20 ` Stefan Roese [this message]
2007-02-17 10:23 ` Harald Welte
2007-02-17 11:16 ` Harald Welte
2007-02-17 14:59 ` Wolfgang Denk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200702170820.22650.sr@denx.de \
--to=sr@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox