From mboxrd@z Thu Jan  1 00:00:00 1970
From: Stefan Roese <sr@denx.de>
Date: Sat, 17 Feb 2007 08:20:22 +0100
Subject: [U-Boot-Users] [PATCH] Add S3C2410 MMC/SD support
In-Reply-To: <528646bc0702161831p4f96dfc0qd6b99626a7e0f856@mail.gmail.com>
References: <20070216230232.GN11991@prithivi.gnumonks.org>
	<528646bc0702161831p4f96dfc0qd6b99626a7e0f856@mail.gmail.com>
Message-ID: <200702170820.22650.sr@denx.de>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

On Saturday 17 February 2007 03:31, Grant Likely wrote:
> Here are some comments after a quick review.

And some more...

<snip>
> > +static u_int32_t *
> > +/****************************************************/
> > +mmc_cmd(ushort cmd, ulong arg, ushort flags)
> > +/****************************************************/
>
> I'm not so fond of the style putting a comment line between the
> function name and the return type.  I think they should be together.
> What does everyone else think?

ACK. Very confusing this way.

Best regards,
Stefan