public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Stefan Roese <sr@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot-Users] [PATCH] Update SystemACE driver for 16bit access
Date: Wed, 21 Feb 2007 20:58:21 +0100	[thread overview]
Message-ID: <200702212058.21563.sr@denx.de> (raw)
In-Reply-To: <528646bc0702210825s6ced876ao20c005e7b838194a@mail.gmail.com>

On Wednesday 21 February 2007 17:25, Grant Likely wrote:
> > @@ -119,6 +119,14 @@ block_dev_desc_t *systemace_get_dev(int dev)
> >                 systemace_dev.removable = 1;
> >                 systemace_dev.block_read = systemace_read;
> >
> > +#if (CFG_SYSTEMACE_WIDTH == 16)
> > +               /*
> > +                * By default the SystemACE comes up in 8-bit mode.
> > +                * Ensure that 16-bit mode gets enabled.
> > +                */
> > +               ace_writew(0x0001, 0);
> > +#endif
> > +
>
> I've got a similar patch in my tree;  How about something like this
> instead:
>
> ace_writew(CFG_SYSTEMACE_WIDTH == 8 ? 0 : 0x0001, 0);
>
> That way it handles both conditions; 8 when it should be 16, and 16
> when it should be 8

Even better. Will update my version.

Best regards,
Stefan

=====================================================================
DENX Software Engineering GmbH, HRB 165235 Munich, CEO: Wolfgang Denk
Office:  Kirchenstr. 5,       D-82194 Groebenzell,            Germany
=====================================================================

      reply	other threads:[~2007-02-21 19:58 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-02-20 12:33 [U-Boot-Users] [PATCH] Update SystemACE driver for 16bit access Stefan Roese
2007-02-21 16:25 ` Grant Likely
2007-02-21 19:58   ` Stefan Roese [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200702212058.21563.sr@denx.de \
    --to=sr@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox