From mboxrd@z Thu Jan  1 00:00:00 1970
From: Stefan Roese <sr@denx.de>
Date: Wed, 21 Feb 2007 20:58:21 +0100
Subject: [U-Boot-Users] [PATCH] Update SystemACE driver for 16bit access
In-Reply-To: <528646bc0702210825s6ced876ao20c005e7b838194a@mail.gmail.com>
References: <200702201333.54351.sr@denx.de>
	<528646bc0702210825s6ced876ao20c005e7b838194a@mail.gmail.com>
Message-ID: <200702212058.21563.sr@denx.de>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

On Wednesday 21 February 2007 17:25, Grant Likely wrote:
> > @@ -119,6 +119,14 @@ block_dev_desc_t *systemace_get_dev(int dev)
> >                 systemace_dev.removable = 1;
> >                 systemace_dev.block_read = systemace_read;
> >
> > +#if (CFG_SYSTEMACE_WIDTH == 16)
> > +               /*
> > +                * By default the SystemACE comes up in 8-bit mode.
> > +                * Ensure that 16-bit mode gets enabled.
> > +                */
> > +               ace_writew(0x0001, 0);
> > +#endif
> > +
>
> I've got a similar patch in my tree;  How about something like this
> instead:
>
> ace_writew(CFG_SYSTEMACE_WIDTH == 8 ? 0 : 0x0001, 0);
>
> That way it handles both conditions; 8 when it should be 16, and 16
> when it should be 8

Even better. Will update my version.

Best regards,
Stefan

=====================================================================
DENX Software Engineering GmbH, HRB 165235 Munich, CEO: Wolfgang Denk
Office:  Kirchenstr. 5,       D-82194 Groebenzell,            Germany
=====================================================================